Re: [FFmpeg-devel] [PATCH] pthread_frame: minor simplification to error handling

2017-03-29 Thread Alexander Strasser
On 2017-03-30 00:00 +0200, wm4 wrote: > On Wed, 29 Mar 2017 22:25:48 +0200 > Alexander Strasser wrote: > > > On Mon, 27 Mar 2017 14:28:17 +0200 > > > wm4 wrote: > > > > > > > Get rid of the "ret" variable, and always use err. Report the packet as > > >

Re: [FFmpeg-devel] [PATCH] pthread_frame: minor simplification to error handling

2017-03-29 Thread wm4
On Wed, 29 Mar 2017 22:25:48 +0200 Alexander Strasser wrote: > Hi, > > I already saw this on -cvslog ml, so apparently I am too late... > > On 2017-03-29 12:19 +0200, wm4 wrote: > > On Mon, 27 Mar 2017 14:28:17 +0200 > > wm4 wrote: > > > > > Get rid

Re: [FFmpeg-devel] [PATCH] pthread_frame: minor simplification to error handling

2017-03-29 Thread Alexander Strasser
Hi, I already saw this on -cvslog ml, so apparently I am too late... On 2017-03-29 12:19 +0200, wm4 wrote: > On Mon, 27 Mar 2017 14:28:17 +0200 > wm4 wrote: > > > Get rid of the "ret" variable, and always use err. Report the packet as > > consumed if err is unset. This

Re: [FFmpeg-devel] [PATCH] pthread_frame: minor simplification to error handling

2017-03-29 Thread wm4
On Mon, 27 Mar 2017 14:28:17 +0200 wm4 wrote: > Get rid of the "ret" variable, and always use err. Report the packet as > consumed if err is unset. This should be equivalent to the old code, > which obviously required err=0 for p->result>=0 (and otherwise, > p->result must

[FFmpeg-devel] [PATCH] pthread_frame: minor simplification to error handling

2017-03-27 Thread wm4
Get rid of the "ret" variable, and always use err. Report the packet as consumed if err is unset. This should be equivalent to the old code, which obviously required err=0 for p->result>=0 (and otherwise, p->result must have had the value err was last set to). The code block added by commit