Re: [FFmpeg-devel] [PATCH] qpeg: avoid pointless invalid memcpy()

2015-01-13 Thread Michael Niedermayer
On Tue, Jan 13, 2015 at 02:47:47PM +0100, wm4 wrote: If refdata was NULL, the memcpy() ended up copying the same memory block onto itself, which is not only pointless, but also undefined behavior. --- Someone spotted the issue in valgrind output. --- libavcodec/qpeg.c | 13 +++--

[FFmpeg-devel] [PATCH] qpeg: avoid pointless invalid memcpy()

2015-01-13 Thread wm4
If refdata was NULL, the memcpy() ended up copying the same memory block onto itself, which is not only pointless, but also undefined behavior. --- Someone spotted the issue in valgrind output. --- libavcodec/qpeg.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git