[FFmpeg-devel] [PATCH] removing comma at final enumeration items to fix pedantic warnings

2016-10-19 Thread Michael Behrisch
Signed-off-by: Michael Behrisch --- libavutil/log.h| 2 +- libavutil/pixfmt.h | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/libavutil/log.h b/libavutil/log.h index 0acc1b9..f0a5738 100644 --- a/libavutil/log.h +++ b/libavutil/log.h @@ -44,7 +44,7 @@ typede

Re: [FFmpeg-devel] [PATCH] removing comma at final enumeration items to fix pedantic warnings

2016-10-19 Thread Michael Niedermayer
On Wed, Oct 19, 2016 at 11:11:21PM +0200, Michael Behrisch wrote: > Signed-off-by: Michael Behrisch > --- > libavutil/log.h| 2 +- > libavutil/pixfmt.h | 12 ++-- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/libavutil/log.h b/libavutil/log.h > index 0acc1b9..f

Re: [FFmpeg-devel] [PATCH] removing comma at final enumeration items to fix pedantic warnings

2016-10-19 Thread Muhammad Faiz
On 10/20/16, Michael Behrisch wrote: > Signed-off-by: Michael Behrisch > --- > libavutil/log.h| 2 +- > libavutil/pixfmt.h | 12 ++-- > 2 files changed, 7 insertions(+), 7 deletions(-) If you have difficulty to send your patch directly (you should use git send-email, not just copy

Re: [FFmpeg-devel] [PATCH] removing comma at final enumeration items to fix pedantic warnings

2016-10-19 Thread Ronald S. Bultje
Hi, On Wed, Oct 19, 2016 at 5:11 PM, Michael Behrisch wrote: > Signed-off-by: Michael Behrisch > --- > libavutil/log.h| 2 +- > libavutil/pixfmt.h | 12 ++-- > 2 files changed, 7 insertions(+), 7 deletions(-) FWIW I still have doubts about this. Ronald _

Re: [FFmpeg-devel] [PATCH] removing comma at final enumeration items to fix pedantic warnings

2016-10-19 Thread Michael Behrisch
Am 20.10.2016 um 04:18 schrieb Muhammad Faiz: > On 10/20/16, Michael Behrisch wrote: >> Signed-off-by: Michael Behrisch >> --- >> libavutil/log.h| 2 +- >> libavutil/pixfmt.h | 12 ++-- >> 2 files changed, 7 insertions(+), 7 deletions(-) > > If you have difficulty to send your patc

Re: [FFmpeg-devel] [PATCH] removing comma at final enumeration items to fix pedantic warnings

2016-10-20 Thread Nicolas George
L'octidi 28 vendémiaire, an CCXXV, Ronald S. Bultje a écrit : > FWIW I still have doubts about this. FWIW, I still have more than doubts about this. This comma is entirely valid. If anything should be changed, it should be to add it where it is missing, for consistency. Regards, -- Nicolas Ge

Re: [FFmpeg-devel] [PATCH] removing comma at final enumeration items to fix pedantic warnings

2016-10-20 Thread Clément Bœsch
On Thu, Oct 20, 2016 at 09:49:40AM +0200, Nicolas George wrote: > L'octidi 28 vendémiaire, an CCXXV, Ronald S. Bultje a écrit : > > FWIW I still have doubts about this. > > FWIW, I still have more than doubts about this. This comma is entirely > valid. If anything should be changed, it should be t

Re: [FFmpeg-devel] [PATCH] removing comma at final enumeration items to fix pedantic warnings

2016-10-20 Thread Nicolas George
Le nonidi 29 vendémiaire, an CCXXV, Clement Boesch a écrit : > it's really a trivial and harmless patch. Which is not enough to accept it. I am sure there are better uses of contributors' time than that. Regards, -- Nicolas George signature.asc Description: Digital signature __

Re: [FFmpeg-devel] [PATCH] removing comma at final enumeration items to fix pedantic warnings

2016-10-20 Thread Clément Bœsch
On Thu, Oct 20, 2016 at 09:55:17AM +0200, Nicolas George wrote: > Le nonidi 29 vendémiaire, an CCXXV, Clement Boesch a écrit : > > it's really a trivial and harmless patch. > > Which is not enough to accept it. > but the patch is perfectly fine and semantically more correct (it explicits that it

Re: [FFmpeg-devel] [PATCH] removing comma at final enumeration items to fix pedantic warnings

2016-10-20 Thread Carl Eugen Hoyos
2016-10-20 9:55 GMT+02:00 Nicolas George : > I am sure there are better uses of contributors' time than that. After many years on this list, I don't think this is a helpful approach. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

Re: [FFmpeg-devel] [PATCH] removing comma at final enumeration items to fix pedantic warnings

2016-10-21 Thread Michael Behrisch
Am 20.10.2016 um 10:00 schrieb Clément Bœsch: > On Thu, Oct 20, 2016 at 09:55:17AM +0200, Nicolas George wrote: >> Le nonidi 29 vendémiaire, an CCXXV, Clement Boesch a écrit : >>> it's really a trivial and harmless patch. >> >> Which is not enough to accept it. >> > > but the patch is perfectly fi

Re: [FFmpeg-devel] [PATCH] removing comma at final enumeration items to fix pedantic warnings

2016-10-25 Thread Michael Behrisch
Hi all, Am 21.10.2016 um 10:32 schrieb Michael Behrisch: > Am 20.10.2016 um 10:00 schrieb Clément Bœsch: >> On Thu, Oct 20, 2016 at 09:55:17AM +0200, Nicolas George wrote: >>> Le nonidi 29 vendémiaire, an CCXXV, Clement Boesch a écrit : it's really a trivial and harmless patch. >>> >>> Which

Re: [FFmpeg-devel] [PATCH] removing comma at final enumeration items to fix pedantic warnings

2016-10-26 Thread Clément Bœsch
On Fri, Oct 21, 2016 at 10:32:58AM +0200, Michael Behrisch wrote: > Am 20.10.2016 um 10:00 schrieb Clément Bœsch: > > On Thu, Oct 20, 2016 at 09:55:17AM +0200, Nicolas George wrote: > >> Le nonidi 29 vendémiaire, an CCXXV, Clement Boesch a écrit : > >>> it's really a trivial and harmless patch. > >