Re: [FFmpeg-devel] [PATCH] rtsp protocol : teardown packet not sent

2015-10-21 Thread Nicolas Adenis-Lamarre
>> Any I/O can cause delay. When the user close the window, they want it to >> close immediately, not in five seconds. Can you confirm that the problem is blocking io, and more generally blocking system calls more than just io ? (i mean, we must take no risk to have to wait, versus doing some non

Re: [FFmpeg-devel] [PATCH] rtsp protocol : teardown packet not sent

2015-10-20 Thread Michael Niedermayer
On Sun, Oct 18, 2015 at 10:13:29PM +0200, Nicolas Adenis-Lamarre wrote: > The rtsp protocol requires the client to send a packet at the end of the > connexion. > FFmpeg basic network function check wether the user aborted the > communication and don't send the packet in this case. > So the

Re: [FFmpeg-devel] [PATCH] rtsp protocol : teardown packet not sent

2015-10-20 Thread Nicolas Adenis-Lamarre
Let's take the example of ffplay in which the code always fails. ie : ffplay 'rtsp:// mafreebox.freebox.fr/fbxtv_pub/stream?namespace=1=201=ld' fails to respect the protocol in 100% of the cases. When i close the window, ffplay.c : stream_close() is called => is->abort_request = 1; =>

Re: [FFmpeg-devel] [PATCH] rtsp protocol : teardown packet not sent

2015-10-20 Thread Michael Niedermayer
On Tue, Oct 20, 2015 at 06:16:12PM +0200, Nicolas Adenis-Lamarre wrote: > Let's take the example of ffplay in which the code always fails. > ie : ffplay 'rtsp:// > mafreebox.freebox.fr/fbxtv_pub/stream?namespace=1=201=ld' > fails to respect the protocol in 100% of the cases. > > When i close the

Re: [FFmpeg-devel] [PATCH] rtsp protocol : teardown packet not sent

2015-10-20 Thread Nicolas George
Le nonidi 29 vendémiaire, an CCXXIV, Nicolas Adenis-Lamarre a écrit : > Probably i misunderstood again, but, > I don't understand however in which case an application would use a > callback to avoid any io at all. > For example, i don't understand why ffplay, when a user close the window, > choose

Re: [FFmpeg-devel] [PATCH] rtsp protocol : teardown packet not sent

2015-10-20 Thread Nicolas Adenis-Lamarre
Thanks for your answer. Thanks for your light. It's clear that my patch is wrong (even if it makes ffplay working). I've 2 solutions at the end, i hope that one of them could be valid for you. For the moment, i still don't know what is the best way to fix it. Probably i misunderstood again, but,

[FFmpeg-devel] [PATCH] rtsp protocol : teardown packet not sent

2015-10-18 Thread Nicolas Adenis-Lamarre
The rtsp protocol requires the client to send a packet at the end of the connexion. FFmpeg basic network function check wether the user aborted the communication and don't send the packet in this case. So the protocol is not respected. This commit removes the check. An other possibility would have