Re: [FFmpeg-devel] [PATCH] swresample/options: enable linear_interp and exact_rational by default

2017-03-16 Thread Muhammad Faiz
On Fri, Mar 17, 2017 at 7:09 AM, wm4 wrote: > On Fri, 10 Mar 2017 09:19:38 +0700 > Muhammad Faiz wrote: > >> for higher quality resampling >> >> Signed-off-by: Muhammad Faiz >> --- > > This patch triggers this assertion: > > Assertion

Re: [FFmpeg-devel] [PATCH] swresample/options: enable linear_interp and exact_rational by default

2017-03-16 Thread wm4
On Fri, 10 Mar 2017 09:19:38 +0700 Muhammad Faiz wrote: > for higher quality resampling > > Signed-off-by: Muhammad Faiz > --- This patch triggers this assertion: Assertion !c->frac && !c->dst_incr_mod && !c->compensation_distance failed at

Re: [FFmpeg-devel] [PATCH] swresample/options: enable linear_interp and exact_rational by default

2017-03-13 Thread Muhammad Faiz
On Fri, Mar 10, 2017 at 9:43 PM, Muhammad Faiz wrote: > On Fri, Mar 10, 2017 at 5:44 PM, Michael Niedermayer > wrote: >> On Fri, Mar 10, 2017 at 11:11:05AM +0700, Muhammad Faiz wrote: >>> On Fri, Mar 10, 2017 at 10:44 AM, Michael Niedermayer >>>

Re: [FFmpeg-devel] [PATCH] swresample/options: enable linear_interp and exact_rational by default

2017-03-10 Thread Muhammad Faiz
On Fri, Mar 10, 2017 at 5:44 PM, Michael Niedermayer wrote: > On Fri, Mar 10, 2017 at 11:11:05AM +0700, Muhammad Faiz wrote: >> On Fri, Mar 10, 2017 at 10:44 AM, Michael Niedermayer >> wrote: >> > On Fri, Mar 10, 2017 at 09:19:38AM +0700, Muhammad

Re: [FFmpeg-devel] [PATCH] swresample/options: enable linear_interp and exact_rational by default

2017-03-10 Thread Michael Niedermayer
On Fri, Mar 10, 2017 at 01:49:41PM +0100, Paul B Mahol wrote: > On 3/10/17, Michael Niedermayer wrote: > > On Fri, Mar 10, 2017 at 11:11:05AM +0700, Muhammad Faiz wrote: > >> On Fri, Mar 10, 2017 at 10:44 AM, Michael Niedermayer > >> wrote: > >> >

Re: [FFmpeg-devel] [PATCH] swresample/options: enable linear_interp and exact_rational by default

2017-03-10 Thread Paul B Mahol
On 3/10/17, Michael Niedermayer wrote: > On Fri, Mar 10, 2017 at 11:11:05AM +0700, Muhammad Faiz wrote: >> On Fri, Mar 10, 2017 at 10:44 AM, Michael Niedermayer >> wrote: >> > On Fri, Mar 10, 2017 at 09:19:38AM +0700, Muhammad Faiz wrote: >> >> for

Re: [FFmpeg-devel] [PATCH] swresample/options: enable linear_interp and exact_rational by default

2017-03-10 Thread Michael Niedermayer
On Fri, Mar 10, 2017 at 11:11:05AM +0700, Muhammad Faiz wrote: > On Fri, Mar 10, 2017 at 10:44 AM, Michael Niedermayer > wrote: > > On Fri, Mar 10, 2017 at 09:19:38AM +0700, Muhammad Faiz wrote: > >> for higher quality resampling > > > > can you hear the difference ? > >

Re: [FFmpeg-devel] [PATCH] swresample/options: enable linear_interp and exact_rational by default

2017-03-09 Thread Muhammad Faiz
On Fri, Mar 10, 2017 at 10:44 AM, Michael Niedermayer wrote: > On Fri, Mar 10, 2017 at 09:19:38AM +0700, Muhammad Faiz wrote: >> for higher quality resampling > > can you hear the difference ? Yes, but it is sinesweep test audio, not real music audio. Thank's

Re: [FFmpeg-devel] [PATCH] swresample/options: enable linear_interp and exact_rational by default

2017-03-09 Thread Muhammad Faiz
On Fri, Mar 10, 2017 at 10:04 AM, Marton Balint wrote: > > On Fri, 10 Mar 2017, Muhammad Faiz wrote: > >> for higher quality resampling > > > How much slower is it? Not slower when exact_rational doesn't fail, because it doesn't trigger linear interpolation (even when

Re: [FFmpeg-devel] [PATCH] swresample/options: enable linear_interp and exact_rational by default

2017-03-09 Thread Michael Niedermayer
On Fri, Mar 10, 2017 at 09:19:38AM +0700, Muhammad Faiz wrote: > for higher quality resampling can you hear the difference ? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many things microsoft did are stupid, but not doing something just because microsoft did

Re: [FFmpeg-devel] [PATCH] swresample/options: enable linear_interp and exact_rational by default

2017-03-09 Thread Marton Balint
On Fri, 10 Mar 2017, Muhammad Faiz wrote: for higher quality resampling How much slower is it? Thanks, Marton Signed-off-by: Muhammad Faiz --- doc/resampler.texi | 5 +- libswresample/options.c | 4 +- tests/fate/libswresample.mak | 189

[FFmpeg-devel] [PATCH] swresample/options: enable linear_interp and exact_rational by default

2017-03-09 Thread Muhammad Faiz
for higher quality resampling Signed-off-by: Muhammad Faiz --- doc/resampler.texi | 5 +- libswresample/options.c | 4 +- tests/fate/libswresample.mak | 189 --- tests/ref/acodec/s302m | 6 +-