Re: [FFmpeg-devel] [PATCH] vdpau_mpeg4: Do not fail on unknown profile.

2014-11-02 Thread Reimar Döffinger
On Sun, Nov 02, 2014 at 10:02:50AM +, Carl Eugen Hoyos wrote: > Reimar Döffinger gmx.de> writes: > > > Are there still objections? > > I just wanted to know if we shouldn't always set ASP? > Or at least for everything != SP? I am unsure. It seemed to me this way would be more reliable and e

Re: [FFmpeg-devel] [PATCH] vdpau_mpeg4: Do not fail on unknown profile.

2014-11-02 Thread Carl Eugen Hoyos
Reimar Döffinger gmx.de> writes: > Are there still objections? I just wanted to know if we shouldn't always set ASP? Or at least for everything != SP? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo

Re: [FFmpeg-devel] [PATCH] vdpau_mpeg4: Do not fail on unknown profile.

2014-11-02 Thread Reimar Döffinger
On 01.11.2014, at 13:45, Reimar Döffinger wrote: > This is a regression, previous code did not require > users to set the profile to use VDPAU. > In addition, ASP is a superset of SP, so there is not > even a good reason to require it. Are there still objections? As said, to my knowledge every AS

Re: [FFmpeg-devel] [PATCH] vdpau_mpeg4: Do not fail on unknown profile.

2014-11-01 Thread wm4
On Sat, 1 Nov 2014 15:13:17 +0100 Reimar Döffinger wrote: > On Sat, Nov 01, 2014 at 01:52:17PM +0100, wm4 wrote: > > On Sat, 1 Nov 2014 13:45:46 +0100 > > Reimar Döffinger wrote: > > > > > This is a regression, previous code did not require > > > users to set the profile to use VDPAU. > > > >

Re: [FFmpeg-devel] [PATCH] vdpau_mpeg4: Do not fail on unknown profile.

2014-11-01 Thread Reimar Döffinger
On Sat, Nov 01, 2014 at 01:52:17PM +0100, wm4 wrote: > On Sat, 1 Nov 2014 13:45:46 +0100 > Reimar Döffinger wrote: > > > This is a regression, previous code did not require > > users to set the profile to use VDPAU. > > It still doesn't...? It does if you want the hwaccel API. > There are bas

Re: [FFmpeg-devel] [PATCH] vdpau_mpeg4: Do not fail on unknown profile.

2014-11-01 Thread Reimar Döffinger
On Sat, Nov 01, 2014 at 02:18:06PM +0100, Jean-Baptiste Kempf wrote: > On 01 Nov, Reimar Döffinger wrote : > > This is a regression, previous code did not require > > users to set the profile to use VDPAU. > > If you don't set the profile, how can you know that the hardware > supports it? Firstly

Re: [FFmpeg-devel] [PATCH] vdpau_mpeg4: Do not fail on unknown profile.

2014-11-01 Thread Carl Eugen Hoyos
Jean-Baptiste Kempf videolan.org> writes: > On 01 Nov, Reimar Döffinger wrote : > > This is a regression, previous code did not require > > users to set the profile to use VDPAU. > > If you don't set the profile, how can you know that > the hardware supports it? Does this have any relevance fo

Re: [FFmpeg-devel] [PATCH] vdpau_mpeg4: Do not fail on unknown profile.

2014-11-01 Thread Jean-Baptiste Kempf
On 01 Nov, Reimar Döffinger wrote : > This is a regression, previous code did not require > users to set the profile to use VDPAU. If you don't set the profile, how can you know that the hardware supports it? -- Jean-Baptiste Kempf http://www.jbkempf.com/ - +33 672 704 734 Sent from my Electroni

Re: [FFmpeg-devel] [PATCH] vdpau_mpeg4: Do not fail on unknown profile.

2014-11-01 Thread Carl Eugen Hoyos
Reimar Döffinger gmx.de> writes: > +case FF_PROFILE_UNKNOWN: > case FF_PROFILE_MPEG4_ADVANCED_SIMPLE: > profile = VDP_DECODER_PROFILE_MPEG4_PART2_ASP; Could instead be the default case to set profile to ASP? Or to remove this whole logic? Carl Eugen __

Re: [FFmpeg-devel] [PATCH] vdpau_mpeg4: Do not fail on unknown profile.

2014-11-01 Thread wm4
On Sat, 1 Nov 2014 13:45:46 +0100 Reimar Döffinger wrote: > This is a regression, previous code did not require > users to set the profile to use VDPAU. It still doesn't...? There are basically 3 ffmpeg vdpau hwaccel APIs now. > In addition, ASP is a superset of SP, so there is not > even a g

[FFmpeg-devel] [PATCH] vdpau_mpeg4: Do not fail on unknown profile.

2014-11-01 Thread Reimar Döffinger
This is a regression, previous code did not require users to set the profile to use VDPAU. In addition, ASP is a superset of SP, so there is not even a good reason to require it. --- libavcodec/vdpau_mpeg4.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/vdpau_mpeg4.c b/libavcodec/