Re: [FFmpeg-devel] [PATCH] vf_colorspace: don't spam console with warnings if range is unspecified.

2016-10-25 Thread Moritz Barsnick
On Sat, Oct 22, 2016 at 22:02:15 -0400, Ronald S. Bultje wrote: > I was hoping for documentation on what it expects, not what can be changed > about it :) Anyway, I'll change it, I don't really care. I had found this to be quite clear: > End with a comment. The checker assumes that this comment is

Re: [FFmpeg-devel] [PATCH] vf_colorspace: don't spam console with warnings if range is unspecified.

2016-10-24 Thread Ronald S. Bultje
Hi, On Sat, Oct 22, 2016 at 10:02 PM, Ronald S. Bultje wrote: > Hi, > > On Sat, Oct 22, 2016 at 12:19 PM, Moritz Barsnick > wrote: > >> On Sat, Oct 22, 2016 at 08:43:26 -0400, Ronald S. Bultje wrote: >> > Is there documentation on what coverity expects? >> >> I found this: >> https://lost-conta

Re: [FFmpeg-devel] [PATCH] vf_colorspace: don't spam console with warnings if range is unspecified.

2016-10-22 Thread Ronald S. Bultje
Hi, On Sat, Oct 22, 2016 at 12:19 PM, Moritz Barsnick wrote: > On Sat, Oct 22, 2016 at 08:43:26 -0400, Ronald S. Bultje wrote: > > Is there documentation on what coverity expects? > > I found this: > https://lost-contact.mit.edu/afs/cs.stanford.edu/pkg/ > prevent-4.3.1/i386_linux26/opt/prevent-l

Re: [FFmpeg-devel] [PATCH] vf_colorspace: don't spam console with warnings if range is unspecified.

2016-10-22 Thread Moritz Barsnick
On Sat, Oct 22, 2016 at 08:43:26 -0400, Ronald S. Bultje wrote: > Is there documentation on what coverity expects? I found this: https://lost-contact.mit.edu/afs/cs.stanford.edu/pkg/prevent-4.3.1/i386_linux26/opt/prevent-linux-4.3.1/cgi-bin/doc/checker_ref.html#c_checker_MISSING_BREAK Moritz

Re: [FFmpeg-devel] [PATCH] vf_colorspace: don't spam console with warnings if range is unspecified.

2016-10-22 Thread Ronald S. Bultje
Hi, On Fri, Oct 21, 2016 at 4:36 PM, Moritz Barsnick wrote: > On Thu, Oct 20, 2016 at 12:06:14 -0400, Ronald S. Bultje wrote: > > +s->did_range_warn = 1; > > +} > > // fall-through > > +} > > case AVCOL_RANGE_MPEG: > > The fall-through comment seems misplace

Re: [FFmpeg-devel] [PATCH] vf_colorspace: don't spam console with warnings if range is unspecified.

2016-10-21 Thread Moritz Barsnick
On Thu, Oct 20, 2016 at 12:06:14 -0400, Ronald S. Bultje wrote: > +s->did_range_warn = 1; > +} > // fall-through > +} > case AVCOL_RANGE_MPEG: The fall-through comment seems misplaced now (both logically and probably for Coverity). Moritz

Re: [FFmpeg-devel] [PATCH] vf_colorspace: don't spam console with warnings if range is unspecified.

2016-10-20 Thread Ronald S. Bultje
Hi, On Thu, Oct 20, 2016 at 1:08 PM, Josh de Kock wrote: > On 20/10/2016 17:06, Ronald S. Bultje wrote: > >> --- >> libavfilter/vf_colorspace.c | 12 ++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c >>

Re: [FFmpeg-devel] [PATCH] vf_colorspace: don't spam console with warnings if range is unspecified.

2016-10-20 Thread Josh de Kock
On 20/10/2016 17:06, Ronald S. Bultje wrote: --- libavfilter/vf_colorspace.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c index c74fe00..f64163f 100644 --- a/libavfilter/vf_colorspace.c +++ b/libavfilt

[FFmpeg-devel] [PATCH] vf_colorspace: don't spam console with warnings if range is unspecified.

2016-10-20 Thread Ronald S. Bultje
--- libavfilter/vf_colorspace.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c index c74fe00..f64163f 100644 --- a/libavfilter/vf_colorspace.c +++ b/libavfilter/vf_colorspace.c @@ -163,6 +163,8 @@ typedef