Re: [FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-05-31 Thread Paul B Mahol
On 5/31/17, Matthias Troffaes wrote: > Dear Paul, > > On Wed, May 31, 2017 at 7:59 PM, Paul B Mahol wrote: >> This code does not belong in this filter. >> >> Make new filter instead. > > May I kindly ask why you think so? I considered this as well but then > decided against it, as this new filter

Re: [FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-05-31 Thread wm4
On Wed, 31 May 2017 20:59:07 +0200 Paul B Mahol wrote: > On 5/31/17, Matthias Troffaes wrote: > > Dear Moritz, > > > > On Wed, May 31, 2017 at 2:17 PM, Moritz Barsnick wrote: > >> On Wed, May 31, 2017 at 13:31:14 +0100, Matthias C. M. Troffaes wrote: > >>> @@ -2,6 +2,7 @@ Entries are sorted

Re: [FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-05-31 Thread Matthias Troffaes
Dear Paul, On Wed, May 31, 2017 at 7:59 PM, Paul B Mahol wrote: > This code does not belong in this filter. > > Make new filter instead. May I kindly ask why you think so? I considered this as well but then decided against it, as this new filter would behave like framestep as a common special ca

Re: [FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-05-31 Thread Paul B Mahol
On 5/31/17, Matthias Troffaes wrote: > Dear Moritz, > > On Wed, May 31, 2017 at 2:17 PM, Moritz Barsnick wrote: >> On Wed, May 31, 2017 at 13:31:14 +0100, Matthias C. M. Troffaes wrote: >>> @@ -2,6 +2,7 @@ Entries are sorted chronologically from oldest to >>> youngest within each release, >>> re

Re: [FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-05-31 Thread Matthias Troffaes
Dear Moritz, On Wed, May 31, 2017 at 2:17 PM, Moritz Barsnick wrote: > On Wed, May 31, 2017 at 13:31:14 +0100, Matthias C. M. Troffaes wrote: >> @@ -2,6 +2,7 @@ Entries are sorted chronologically from oldest to youngest >> within each release, >> releases are sorted from youngest to oldest. >>

Re: [FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-05-31 Thread Moritz Barsnick
On Wed, May 31, 2017 at 13:31:14 +0100, Matthias C. M. Troffaes wrote: > @@ -2,6 +2,7 @@ Entries are sorted chronologically from oldest to youngest > within each release, > releases are sorted from youngest to oldest. > > version : > +- framestep filter: add blend parameter for motion blur eff

Re: [FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-05-31 Thread Matthias Troffaes
Note that this is a resubmission of https://ffmpeg.org/pipermail/ffmpeg-devel/2017-April/209794.html - in particular the mips test failure reported in https://ffmpeg.org/pipermail/ffmpeg-devel/2017-April/209820.html has been fixed. Kind regards, Matthias On Wed, May 31, 2017 at 1:31 PM, Matthias

[FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-05-31 Thread Matthias C. M. Troffaes
This patch adds a "blend" parameter to the framestep filter, to blend frames together at each step, for a motion blur effect. The number of frames that are blended (i.e. the exposure time, in frames) can be controlled, allowing control over the strength of the motion blur. The filter has timeline s

Re: [FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-04-07 Thread Matthias Troffaes
On Thu, Apr 6, 2017 at 5:00 PM, Michael Niedermayer wrote: > On Thu, Apr 06, 2017 at 02:09:46PM +0100, Matthias Troffaes wrote: >> Many thanks for your feedback, Michael and Nicolas. >> >> On Wed, Apr 5, 2017 at 7:02 PM, Michael Niedermayer >> wrote: >> > fails on qemu mips >> >> Thank you for fl

Re: [FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-04-06 Thread Michael Niedermayer
On Thu, Apr 06, 2017 at 02:09:46PM +0100, Matthias Troffaes wrote: > Many thanks for your feedback, Michael and Nicolas. > > On Wed, Apr 5, 2017 at 7:02 PM, Michael Niedermayer > wrote: > > fails on qemu mips > > Thank you for flagging this failure. I'm currently trying to reproduce > the proble

Re: [FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-04-06 Thread Matthias Troffaes
Many thanks for your feedback, Michael and Nicolas. On Wed, Apr 5, 2017 at 7:02 PM, Michael Niedermayer wrote: > fails on qemu mips Thank you for flagging this failure. I'm currently trying to reproduce the problem. May I ask what toolchain you typically use to compile to mips? (I'm trying debia

Re: [FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-04-06 Thread Nicolas George
Le sextidi 16 germinal, an CCXXV, Matthias C. M. Troffaes a écrit : > +#define DEFINE_BLEND(NAME, TYPE, DECL, EXPR) > \ > +static void blend_##NAME##_##TYPE(AVFilterContext *ctx, AVFrame *in, int > plane)\ > +{

Re: [FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-04-05 Thread Michael Niedermayer
On Wed, Apr 05, 2017 at 02:00:28PM +0100, Matthias C. M. Troffaes wrote: > --- > Changelog | 1 + > doc/filters.texi | 7 ++ > libavfilter/vf_framestep.c| 242 > ++ > tests/fate/filter-video.mak | 5 +

[FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-04-05 Thread Matthias C. M. Troffaes
Attached a patch which adds a "blend" parameter to the framestep filter, to blend frames together at each step, for a motion blur effect. The number of frames that are blended (i.e. the exposure time, in frames) can be controlled, allowing control over the strength of the motion blur. The filter ha

[FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-04-05 Thread Matthias C. M. Troffaes
--- Changelog | 1 + doc/filters.texi | 7 ++ libavfilter/vf_framestep.c| 242 ++ tests/fate/filter-video.mak | 5 + tests/ref/fate/filter-framestep-1 | 17 +++ tests/ref/fate/filter-framestep-2 | 17