Re: [FFmpeg-devel] [PATCH] vp9:enable multi-thread decoding when refreshctx is equal to 0

2014-10-10 Thread Reynaldo H. Verdejo Pinochet
On 10/09/2014 11:16 PM, Di Wu wrote: [..] Thank you for your suggestion. I make the change in the else if branch and do some improvement follow Reynaldo's suggestions, and create a new patch. Because braces are used in if() branch, I also use braces in else if() branch. If this doesn't meent th

Re: [FFmpeg-devel] [PATCH] vp9:enable multi-thread decoding when refreshctx is equal to 0

2014-10-10 Thread Ronald S. Bultje
Hi, On Thu, Oct 9, 2014 at 10:16 PM, Di Wu wrote: > Hi, > > On 10/9/2014 08:46 AM, Ronald wrote: > > > I think functionally this looks OK, thanks for finding it. Please do > follow > > Reynaldo's suggestions on style/cosmetics. I'd go as far as to change the > > second if into an else if, s

Re: [FFmpeg-devel] [PATCH] vp9:enable multi-thread decoding when refreshctx is equal to 0

2014-10-09 Thread Di Wu
Hi, On 10/9/2014 08:46 AM, Ronald wrote: > I think functionally this looks OK, thanks for finding it. Please do follow > Reynaldo's suggestions on style/cosmetics. I'd go as far as to change the > second if into an else if, since they do related stuff, but I don't mind > either way. On

Re: [FFmpeg-devel] [PATCH] vp9:enable multi-thread decoding when refreshctx is equal to 0

2014-10-09 Thread Di Wu
<<< image/gif; name="201410100943737_4XEV4D4T.gif": Unrecognized >>> 0001-vp9-enable-multi-thread-decoding-when-refreshctx-is-.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH] vp9:enable multi-thread decoding when refreshctx is equal to 0

2014-10-09 Thread Di Wu
<<< image/gif; name="201410091817425_Z5JE7EUA.gif": Unrecognized >>> 0001-vp9-enable-multi-thread-decoding-when-refreshctx-is-.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH] vp9:enable multi-thread decoding when refreshctx is equal to 0

2014-10-08 Thread Ronald S. Bultje
Hi, On Thu, Oct 9, 2014 at 3:41 PM, wrote: > From: Di Wu > > Multi-thread decoding doesn't work when refreshctx is equal to 0. Fix > it by call ff_thread_finish_setup function in the condition when > refreshctx is equal to 0. > > In vp9_decode_frame function, ff_thread_finish_setup is not calle

Re: [FFmpeg-devel] [PATCH] vp9:enable multi-thread decoding when refreshctx is equal to 0

2014-10-08 Thread Reynaldo H. Verdejo Pinochet
Hello, thanks for your patch. Comments bellow: On 10/09/2014 04:41 PM, di1028...@samsung.com wrote: > From: Di Wu > > Multi-thread decoding doesn't work when refreshctx is equal to 0. Fix > it by call ff_thread_finish_setup function in the condition when > refreshctx is equal to 0. > > In vp9_d

[FFmpeg-devel] [PATCH] vp9:enable multi-thread decoding when refreshctx is equal to 0

2014-10-07 Thread di1028 . wu
From: Di Wu Multi-thread decoding doesn't work when refreshctx is equal to 0. Fix it by call ff_thread_finish_setup function in the condition when refreshctx is equal to 0. In vp9_decode_frame function, ff_thread_finish_setup is not called when refreshctx is equal to 0. The next decoding thread