Re: [FFmpeg-devel] [PATCH] x86/doc/Makefile: DBG=1 to preprocess external asm

2015-02-21 Thread Michael Niedermayer
On Wed, Feb 18, 2015 at 10:57:20AM +0100, Christophe Gisquet wrote: > Hi, > > 2015-02-17 20:06 GMT+01:00 James Almer : > > $ make libavcodec/x86/dcadsp.o DBG=0 > > OK, it's mainly a matter of documentation then here, as just having > DBG defined is fine. I'm not sure of the makefile syntax if DBG

Re: [FFmpeg-devel] [PATCH] x86/doc/Makefile: DBG=1 to preprocess external asm

2015-02-18 Thread Christophe Gisquet
Hi, 2015-02-17 20:06 GMT+01:00 James Almer : > $ make libavcodec/x86/dcadsp.o DBG=0 OK, it's mainly a matter of documentation then here, as just having DBG defined is fine. I'm not sure of the makefile syntax if DBG=1 is what is really wanted. > YASMlibavcodec/x86/dcadsp.dbg.asm > YASMli

Re: [FFmpeg-devel] [PATCH] x86/doc/Makefile: DBG=1 to preprocess external asm

2015-02-17 Thread James Almer
On 17/02/15 9:21 AM, Michael Niedermayer wrote: > On Sun, Feb 08, 2015 at 02:54:25PM +0100, Christophe Gisquet wrote: >> Hi, >> >> 2015-02-08 14:07 GMT+01:00 Carl Eugen Hoyos : >>> Doesn't this also need an update for "make clean"? >> >> Right, here's an updated one, also improving dependency gener

Re: [FFmpeg-devel] [PATCH] x86/doc/Makefile: DBG=1 to preprocess external asm

2015-02-17 Thread Christophe Gisquet
Hi, 2015-02-17 13:29 GMT+01:00 Michael Niedermayer : > also, i wonder, should this be extended to also work with C files ? Again, with asm, macro hell sometimes gives you that. So it makes sense. I don't know well enough icc/llvm/whatever we handle, so the main issue might be to ask the compiler

Re: [FFmpeg-devel] [PATCH] x86/doc/Makefile: DBG=1 to preprocess external asm

2015-02-17 Thread Michael Niedermayer
On Tue, Feb 17, 2015 at 01:25:10PM +0100, Christophe Gisquet wrote: > Hi, > > 2015-02-17 13:21 GMT+01:00 Michael Niedermayer : > > btw, this works too: (without DBG=1) > > make V=2 libavcodec/x86/vp8dsp_loopfilter.dbg.o > > Yeah, once I'm working on a specific file, that's what I do. > > But iir

Re: [FFmpeg-devel] [PATCH] x86/doc/Makefile: DBG=1 to preprocess external asm

2015-02-17 Thread Christophe Gisquet
Hi, 2015-02-17 13:21 GMT+01:00 Michael Niedermayer : > btw, this works too: (without DBG=1) > make V=2 libavcodec/x86/vp8dsp_loopfilter.dbg.o Yeah, once I'm working on a specific file, that's what I do. But iirc, you can just do make DBG=1 and wait for any error to mention the offending .dbg.asm

Re: [FFmpeg-devel] [PATCH] x86/doc/Makefile: DBG=1 to preprocess external asm

2015-02-17 Thread Michael Niedermayer
On Sun, Feb 08, 2015 at 02:54:25PM +0100, Christophe Gisquet wrote: > Hi, > > 2015-02-08 14:07 GMT+01:00 Carl Eugen Hoyos : > > Doesn't this also need an update for "make clean"? > > Right, here's an updated one, also improving dependency generation and > allowing more genering (for now) code. >

Re: [FFmpeg-devel] [PATCH] x86/doc/Makefile: DBG=1 to preprocess external asm

2015-02-16 Thread Christophe Gisquet
Hi, 2015-02-08 14:54 GMT+01:00 Christophe Gisquet : > 2015-02-08 14:07 GMT+01:00 Carl Eugen Hoyos : >> Doesn't this also need an update for "make clean"? > > Right, here's an updated one, also improving dependency generation and > allowing more genering (for now) code. Ping? I can probably live

Re: [FFmpeg-devel] [PATCH] x86/doc/Makefile: DBG=1 to preprocess external asm

2015-02-08 Thread Christophe Gisquet
Hi, 2015-02-08 14:07 GMT+01:00 Carl Eugen Hoyos : > Doesn't this also need an update for "make clean"? Right, here's an updated one, also improving dependency generation and allowing more genering (for now) code. -- Christophe From 6795382920c90fdf7e9cef5031627534c9df15b3 Mon Sep 17 00:00:00 20

Re: [FFmpeg-devel] [PATCH] x86/doc/Makefile: DBG=1 to preprocess external asm

2015-02-08 Thread Carl Eugen Hoyos
Christophe Gisquet gmail.com> writes: > Suggestions for more efficient make rules, clearer documentation > and a better macro than the generic 'DBG' welcome. Doesn't this also need an update for "make clean"? Carl Eugen ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] x86/doc/Makefile: DBG=1 to preprocess external asm

2015-02-08 Thread Christophe Gisquet
Suggestions for more efficient make rules, clearer documentation and a better macro than the generic 'DBG' welcome. -- Christophe From 8e2adea82a4ec440744b701716a93e6ecaf211d6 Mon Sep 17 00:00:00 2001 From: Christophe Gisquet Date: Sun, 8 Feb 2015 12:18:27 +0100 Subject: [PATCH] x86/doc/Makefile