Re: [FFmpeg-devel] [PATCH] x86: Remove MMX assembly rv34_inv_transform_dc in rv34dsp

2024-02-13 Thread flow gg
I made a mistake. It can be fixed your way. Please ignore this reply. flow gg 于2024年2月13日周二 17:47写道: > Thank you for your guidance. Do you mean that it should be modified test > like this? > > - declare_func(void, uint8_t *dst, ptrdiff_t stride, int dc); > + declare_func_emms(AV_CPU_FLAG_MMX, vo

Re: [FFmpeg-devel] [PATCH] x86: Remove MMX assembly rv34_inv_transform_dc in rv34dsp

2024-02-13 Thread flow gg
Thank you for your guidance. Do you mean that it should be modified test like this? - declare_func(void, uint8_t *dst, ptrdiff_t stride, int dc); + declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *, ptrdiff_t, int); I tried to do it this way, but the test still failed. not sure why ... _

Re: [FFmpeg-devel] [PATCH] x86: Remove MMX assembly rv34_inv_transform_dc in rv34dsp

2024-02-13 Thread Andreas Rheinhardt
flow gg: > Subject: [PATCH] x86: Remove MMX assembly rv34_inv_transform_dc in rv34dsp > > This asm will cause checkasm to fail. > --- > libavcodec/x86/rv34dsp.asm| 12 > libavcodec/x86/rv34dsp_init.c | 2 -- Of course your checkasm test will fail: You used declare_func and not d

[FFmpeg-devel] [PATCH] x86: Remove MMX assembly rv34_inv_transform_dc in rv34dsp

2024-02-12 Thread flow gg
checkasm in [FFmpeg-devel] [PATCH 1/4] checkasm/rv34dsp: add rv34_inv_transform_dc test From 1aa51d60def8d4313c1b11a50528662ec832530e Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Tue, 13 Feb 2024 08:41:20 +0800 Subject: [PATCH] x86: Remove MMX assembly rv34_inv_transform_dc in rv34dsp This asm