Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-03 Thread Mickaël Raulet
it works now for me. Thanks, Mickaël Le 3 févr. 2015 à 15:28, Mickaël Raulet a écrit : > I will check it this evening. > > Mickaël > > 2015-02-03 15:15 GMT+01:00 Christophe Gisquet : > 2015-02-03 12:57 GMT+01:00 Christophe Gisquet : > > Actually, 940300945 does need to be reverted for the pa

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-03 Thread James Almer
On 03/02/15 4:04 PM, Christophe Gisquet wrote: > ​​Hi, > > Le 3 févr. 2015 18:47, "James Almer" a écrit : >> >> On 02/02/15 2:11 PM, Christophe Gisquet wrote: >>> @@ -87,11 +95,22 @@ QPEL_TABLE 12, 4, w, sse4 >>> %elif %1 <= 8 >>> movdqa%3, > [%2]

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-03 Thread Christophe Gisquet
​​Hi, Le 3 févr. 2015 18:47, "James Almer" a écrit : > > On 02/02/15 2:11 PM, Christophe Gisquet wrote: > > @@ -87,11 +95,22 @@ QPEL_TABLE 12, 4, w, sse4 > > %elif %1 <= 8 > > movdqa%3, [%2] ; load data from source2 > > %elif %1 <= 1

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-03 Thread James Almer
On 02/02/15 2:11 PM, Christophe Gisquet wrote: > @@ -87,11 +95,22 @@ QPEL_TABLE 12, 4, w, sse4 > %elif %1 <= 8 > movdqa%3, [%2] > ; load data from source2 > %elif %1 <= 12 > +%if avx_enabled If this is meant for avx2, then the correc

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-03 Thread James Almer
On 03/02/15 11:15 AM, Christophe Gisquet wrote: > 2015-02-03 12:57 GMT+01:00 Christophe Gisquet : >> Actually, 940300945 does need to be reverted for the patch to work, as >> Mickael stated. It miscompiles hevc_mc.asm, more particularly the >> [eq]pel_hv functions. No idea why. > > The patch in "[

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-03 Thread Mickaël Raulet
I will check it this evening. Mickaël 2015-02-03 15:15 GMT+01:00 Christophe Gisquet : > 2015-02-03 12:57 GMT+01:00 Christophe Gisquet < > christophe.gisq...@gmail.com>: > > Actually, 940300945 does need to be reverted for the patch to work, as > > Mickael stated. It miscompiles hevc_mc.asm, mor

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-03 Thread Christophe Gisquet
2015-02-03 12:57 GMT+01:00 Christophe Gisquet : > Actually, 940300945 does need to be reverted for the patch to work, as > Mickael stated. It miscompiles hevc_mc.asm, more particularly the > [eq]pel_hv functions. No idea why. The patch in "[PATCH] x86: lavu/x264asm: fix ymm register instanciation"

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-03 Thread Christophe Gisquet
Hi, 2015-02-02 18:23 GMT+01:00 James Almer : >>> https://github.com/OpenHEVC/FFmpeg/commit/940300945995c20f7583394ebe6907e72829b4a [...] > Tested it. Doesn't pass with avx2. Actually, 940300945 does need to be reverted for the patch to work, as Mickael stated. It miscompiles hevc_mc.asm, more par

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-02 Thread James Almer
On 02/02/15 2:11 PM, Christophe Gisquet wrote: > Hi, > > 2015-02-02 17:16 GMT+01:00 Mickaël Raulet : >> https://github.com/OpenHEVC/FFmpeg/commit/940300945995c20f7583394ebe6907e72829b4a > > No longer apply cleanly, as multiple fixes and improvements have been > committed since then. > > The atta

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-02 Thread Mickaël Raulet
PL Lepere is the original author and I did some improvements on top of it. Mickael 2015-02-02 18:11 GMT+01:00 Christophe Gisquet : > Hi, > > 2015-02-02 17:16 GMT+01:00 Mickaël Raulet : > > > https://github.com/OpenHEVC/FFmpeg/commit/940300945995c20f7583394ebe6907e72829b4a > > No longer apply c

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-02 Thread Christophe Gisquet
Hi, 2015-02-02 17:16 GMT+01:00 Mickaël Raulet : > https://github.com/OpenHEVC/FFmpeg/commit/940300945995c20f7583394ebe6907e72829b4a No longer apply cleanly, as multiple fixes and improvements have been committed since then. The attached patch fixes that, and passes on a non-avx2 machine. I can't

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-02 Thread Mickaël Raulet
Hi christophe, I was willing to send avx2 mc patch, but I need to test it on top of ffmpeg head. Last time I tried I had to revert 940300945995c20f7583394ebe6907e72829b4a. https://github.com/OpenHEVC/FFmpeg/commit/940300945995c20f7583394ebe6907e72829b4a . Here is the avx2 implementation if someo

[FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-02 Thread Christophe Gisquet
This is not a clean equivalent of the openhevc patch, as we don't have the same history on hevc_mc. -- Christophe From 0eedfb7d5902cc388d018111c670cc31ad22db60 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micka=C3=ABl=20Raulet?= Date: Thu, 31 Jul 2014 19:26:57 +0200 Subject: [PATCH] x86: hevc_mc: re