Re: [FFmpeg-devel] [PATCH]Bump probesize and analyzeduration to 64bit (again)

2015-09-15 Thread James Almer
On 9/15/2015 1:29 PM, Carl Eugen Hoyos wrote: > James Almer gmail.com> writes: > >> On 9/12/2015 3:42 PM, Michael Niedermayer wrote: >>> I think theres consense about "abi compatibility" so i >>> would tend to suggest to move forward with that in mind. >> >> In that case we should go ahead and d

Re: [FFmpeg-devel] [PATCH]Bump probesize and analyzeduration to 64bit (again)

2015-09-15 Thread Carl Eugen Hoyos
James Almer gmail.com> writes: > On 9/12/2015 3:42 PM, Michael Niedermayer wrote: > > I think theres consense about "abi compatibility" so i > > would tend to suggest to move forward with that in mind. > > In that case we should go ahead and don't bother with the > AV_HAVE_INCOMPATIBLE_LIBAV_AB

Re: [FFmpeg-devel] [PATCH]Bump probesize and analyzeduration to 64bit (again)

2015-09-12 Thread Carl Eugen Hoyos
James Almer gmail.com> writes: > "NO direct access" will now apply to the new > max_analyze_duration and probesize fields when > incompatible-libav-abi is not used. Is that > intended? This is how the patch was ok'ed before. I am 100% fine with moving the 64 bit fields, but it is imo unrelat

Re: [FFmpeg-devel] [PATCH]Bump probesize and analyzeduration to 64bit (again)

2015-09-12 Thread James Almer
On 9/12/2015 3:42 PM, Michael Niedermayer wrote: > I think theres consense about "abi compatibility" so i would tend to > suggest to move forward with that in mind. In that case we should go ahead and don't bother with the AV_HAVE_INCOMPATIBLE_LIBAV_ABI check at all for this change. __

Re: [FFmpeg-devel] [PATCH]Bump probesize and analyzeduration to 64bit (again)

2015-09-12 Thread Michael Niedermayer
On Sat, Sep 12, 2015 at 03:37:08PM -0300, James Almer wrote: > On 9/12/2015 3:28 PM, Michael Niedermayer wrote: > > On Sat, Sep 12, 2015 at 03:25:05PM -0300, James Almer wrote: > >> On 9/12/2015 3:04 PM, Carl Eugen Hoyos wrote: > >>> Hi! > >>> > >>> Attached patch implements making probesize and an

Re: [FFmpeg-devel] [PATCH]Bump probesize and analyzeduration to 64bit (again)

2015-09-12 Thread James Almer
On 9/12/2015 3:28 PM, Michael Niedermayer wrote: > On Sat, Sep 12, 2015 at 03:25:05PM -0300, James Almer wrote: >> On 9/12/2015 3:04 PM, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> Attached patch implements making probesize and analyzeduration 64bit >>> unless api compatibility was requested. >>> >>>

Re: [FFmpeg-devel] [PATCH]Bump probesize and analyzeduration to 64bit (again)

2015-09-12 Thread Michael Niedermayer
On Sat, Sep 12, 2015 at 03:25:05PM -0300, James Almer wrote: > On 9/12/2015 3:04 PM, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch implements making probesize and analyzeduration 64bit > > unless api compatibility was requested. > > > > I will add a line to doc/APIchanges and do a minor

Re: [FFmpeg-devel] [PATCH]Bump probesize and analyzeduration to 64bit (again)

2015-09-12 Thread James Almer
On 9/12/2015 3:04 PM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch implements making probesize and analyzeduration 64bit > unless api compatibility was requested. > > I will add a line to doc/APIchanges and do a minor version bump. > > Please review, this cannot wait, Carl Eugen You're rem

Re: [FFmpeg-devel] [PATCH]Bump probesize and analyzeduration to 64bit (again)

2015-09-12 Thread Michael Niedermayer
On Sat, Sep 12, 2015 at 08:04:34PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch implements making probesize and analyzeduration 64bit > unless api compatibility was requested. > > I will add a line to doc/APIchanges and do a minor version bump. > > Please review, this cannot wait, Ca

[FFmpeg-devel] [PATCH]Bump probesize and analyzeduration to 64bit (again)

2015-09-12 Thread Carl Eugen Hoyos
Hi! Attached patch implements making probesize and analyzeduration 64bit unless api compatibility was requested. I will add a line to doc/APIchanges and do a minor version bump. Please review, this cannot wait, Carl Eugen diff --git a/libavformat/avformat.h b/libavformat/avformat.h index b7f18c