Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-27 Thread Carl Eugen Hoyos
Reimar Döffinger Reimar.Doeffinger at gmx.de writes: Currently no relevant codecs use 12 bits, which is the reason why 9 and 10 bits exist as separate formats while 12 bits does not. Do you believe that x264 code would have to be less efficient than it is now if the 9 and 10 bit

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-27 Thread Reimar Döffinger
On 27.08.2014, at 16:41, Carl Eugen Hoyos ceho...@ag.or.at wrote: Reimar Döffinger Reimar.Doeffinger at gmx.de writes: Currently no relevant codecs use 12 bits, which is the reason why 9 and 10 bits exist as separate formats while 12 bits does not. Do you believe that x264 code would

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-26 Thread Reimar Döffinger
On 25.08.2014, at 19:33, Christophe Gisquet christophe.gisq...@gmail.com wrote: Hi, 2014-08-25 6:41 GMT+02:00 Reimar Döffinger reimar.doeffin...@gmx.de: The colorspace is supposed to be authoritative. If it says 16 bit, then showing it as 16 bit must work properly. The only intention of

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-25 Thread Christophe Gisquet
Hi, 2014-08-25 6:41 GMT+02:00 Reimar Döffinger reimar.doeffin...@gmx.de: The colorspace is supposed to be authoritative. If it says 16 bit, then showing it as 16 bit must work properly. The only intention of bits_per_raw_sample is to indicate that there is no point in storing some of the

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-24 Thread Christophe Gisquet
Hi, 2014-08-24 12:13 GMT+02:00 Carl Eugen Hoyos ceho...@ag.or.at: [...] -if( avctx-bits_per_raw_sample ) +if ( avctx-bits_per_raw_sample + av_pix_fmt_desc_get(avctx-pix_fmt)-comp[0].depth_minus1 7) maxdepth = (1 avctx-bits_per_raw_sample) - 1; So

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-24 Thread Carl Eugen Hoyos
Carl Eugen Hoyos cehoyos at ag.or.at writes: Attached patch fixes pnm encoding for me if bits_per_raw_sample is set to a value different from the pix_fmt's native value. I should have mentioned that this was planned as a [RFC] since I am not completely convinced we want this but current

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-24 Thread Carl Eugen Hoyos
Christophe Gisquet christophe.gisquet at gmail.com writes: Hi, 2014-08-24 12:48 GMT+02:00 Carl Eugen Hoyos cehoyos at ag.or.at: I think [PATCH 2/5] pnmenc: use bits_per_raw_sample is wrong then Definitely, I still wonder how you tested it. ljpeg 36bits from #2966 and having the

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-24 Thread Christophe Gisquet
Hi, I think a first point must be cleared, seeing your reaction to my pnmdec comment. Here' are the opinions: - Mine: bits_per_raw_sample should indicate the dynamics of the signal when it is different from the colorspace bitdepth - ffmpeg's and yours (if I'm not mistaken): the signal bitdepth

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-24 Thread Carl Eugen Hoyos
Christophe Gisquet christophe.gisquet at gmail.com writes: - ffmpeg's and yours (if I'm not mistaken): the signal bitdepth should always match the colorspace one, and bits_per_raw_sample should indicate the original bitdepth I believe that my opinion is mostly irrelevant but that FFmpeg's

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-24 Thread Reimar Döffinger
On 24.08.2014, at 14:02, Christophe Gisquet christophe.gisq...@gmail.com wrote: Hi, I think a first point must be cleared, seeing your reaction to my pnmdec comment. Here' are the opinions: - Mine: bits_per_raw_sample should indicate the dynamics of the signal when it is different from the