Re: [FFmpeg-devel] [PATCH]Remove probesize32 and max_analyze_duration32 on version bump

2015-09-04 Thread James Almer
On 9/4/2015 5:53 AM, Carl Eugen Hoyos wrote: > James Almer gmail.com> writes: > >> Isn't removing these two going to break >> compatibility with libav? > > (ABI or API?) > I don't think so but I absolutely may miss something. > > Carl Eugen ABI, you're removing elements from the middle of

Re: [FFmpeg-devel] [PATCH]Remove probesize32 and max_analyze_duration32 on version bump

2015-09-04 Thread Carl Eugen Hoyos
James Almer gmail.com> writes: > >> Isn't removing these two going to break > >> compatibility with libav? > > > > (ABI or API?) > > I don't think so but I absolutely may miss something. > ABI, you're removing elements from the middle of the > struct. In which situation would that be an

Re: [FFmpeg-devel] [PATCH]Remove probesize32 and max_analyze_duration32 on version bump

2015-09-04 Thread James Almer
On 9/4/2015 6:19 PM, Carl Eugen Hoyos wrote: > James Almer gmail.com> writes: Isn't removing these two going to break compatibility with libav? >>> >>> (ABI or API?) >>> I don't think so but I absolutely may miss something. > >> ABI, you're removing elements from the middle of the >>

Re: [FFmpeg-devel] [PATCH]Remove probesize32 and max_analyze_duration32 on version bump

2015-09-04 Thread Hendrik Leppkes
On Fri, Sep 4, 2015 at 11:43 PM, James Almer wrote: > On 9/4/2015 6:19 PM, Carl Eugen Hoyos wrote: >> James Almer gmail.com> writes: > Isn't removing these two going to break > compatibility with libav? (ABI or API?) I don't think so but I absolutely may

Re: [FFmpeg-devel] [PATCH]Remove probesize32 and max_analyze_duration32 on version bump

2015-09-04 Thread wm4
On Fri, 4 Sep 2015 19:42:18 -0300 James Almer wrote: > On 9/4/2015 7:06 PM, Hendrik Leppkes wrote: > > On Fri, Sep 4, 2015 at 11:43 PM, James Almer wrote: > >> On 9/4/2015 6:19 PM, Carl Eugen Hoyos wrote: > >>> James Almer gmail.com> writes: > >> Isn't

Re: [FFmpeg-devel] [PATCH]Remove probesize32 and max_analyze_duration32 on version bump

2015-09-04 Thread James Almer
On 9/4/2015 7:06 PM, Hendrik Leppkes wrote: > On Fri, Sep 4, 2015 at 11:43 PM, James Almer wrote: >> On 9/4/2015 6:19 PM, Carl Eugen Hoyos wrote: >>> James Almer gmail.com> writes: >> Isn't removing these two going to break >> compatibility with libav? > > (ABI

Re: [FFmpeg-devel] [PATCH]Remove probesize32 and max_analyze_duration32 on version bump

2015-09-04 Thread Carl Eugen Hoyos
James Almer gmail.com> writes: > Isn't removing these two going to break > compatibility with libav? (ABI or API?) I don't think so but I absolutely may miss something. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH]Remove probesize32 and max_analyze_duration32 on version bump

2015-09-03 Thread James Almer
On 8/31/2015 6:41 AM, Carl Eugen Hoyos wrote: > diff --git a/libavformat/avformat.h b/libavformat/avformat.h > index e83a374..4068ab6 100644 > --- a/libavformat/avformat.h > +++ b/libavformat/avformat.h > @@ -1396,6 +1396,7 @@ typedef struct AVFormatContext { > #define AVFMT_FLAG_KEEP_SIDE_DATA

Re: [FFmpeg-devel] [PATCH]Remove probesize32 and max_analyze_duration32 on version bump

2015-09-01 Thread Carl Eugen Hoyos
Ronald S. Bultje gmail.com> writes: > > Attached removes two unnecessary context variables > > on version bump, please review. > > lgtm. Patch applied. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH]Remove probesize32 and max_analyze_duration32 on version bump

2015-08-31 Thread Ronald S. Bultje
Hi Carl, On Mon, Aug 31, 2015 at 5:41 AM, Carl Eugen Hoyos wrote: > Hi! > > Attached removes two unnecessary context variables on version bump, please > review. lgtm. Ronald ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH]Remove probesize32 and max_analyze_duration32 on version bump

2015-08-31 Thread Carl Eugen Hoyos
Hi! Attached removes two unnecessary context variables on version bump, please review. Carl Eugen diff --git a/libavformat/avformat.h b/libavformat/avformat.h index e83a374..4068ab6 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -1396,6 +1396,7 @@ typedef struct