Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-29 Thread wm4
On Wed, 29 Mar 2017 09:54:27 +0200 Carl Eugen Hoyos wrote: > 2017-03-27 13:41 GMT+02:00 wm4 : > > On Mon, 27 Mar 2017 13:29:35 +0200 > > Carl Eugen Hoyos wrote: > > > >> 2017-03-27 11:40 GMT+02:00 wm4 : >

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-29 Thread Carl Eugen Hoyos
2017-03-27 13:41 GMT+02:00 wm4 : > On Mon, 27 Mar 2017 13:29:35 +0200 > Carl Eugen Hoyos wrote: > >> 2017-03-27 11:40 GMT+02:00 wm4 : >> > On Mon, 27 Mar 2017 09:31:39 +0200 >> > Carl Eugen Hoyos wrote: >> > >>

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-27 Thread wm4
On Mon, 27 Mar 2017 13:29:35 +0200 Carl Eugen Hoyos wrote: > 2017-03-27 11:40 GMT+02:00 wm4 : > > On Mon, 27 Mar 2017 09:31:39 +0200 > > Carl Eugen Hoyos wrote: > > > >> 2017-03-24 15:16 GMT+01:00 Ronald S. Bultje

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-27 Thread Carl Eugen Hoyos
2017-03-27 11:40 GMT+02:00 wm4 : > On Mon, 27 Mar 2017 09:31:39 +0200 > Carl Eugen Hoyos wrote: > >> 2017-03-24 15:16 GMT+01:00 Ronald S. Bultje : >> In addition, giving the fact that you seem (?) to have stopped >> contributing may

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-27 Thread Paul B Mahol
On 3/27/17, Carl Eugen Hoyos wrote: > 2017-03-24 15:16 GMT+01:00 Ronald S. Bultje : >> There is also the risk with the initial patch that compiling libavcodec >> against a newer libavutil but then runtime linking it with another (older) >> one would lead to

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-27 Thread wm4
On Mon, 27 Mar 2017 09:31:39 +0200 Carl Eugen Hoyos wrote: > 2017-03-24 15:16 GMT+01:00 Ronald S. Bultje : > > There is also the risk with the initial patch that compiling libavcodec > > against a newer libavutil but then runtime linking it with another

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-27 Thread Carl Eugen Hoyos
2017-03-24 15:16 GMT+01:00 Ronald S. Bultje : > There is also the risk with the initial patch that compiling libavcodec > against a newer libavutil but then runtime linking it with another (older) > one would lead to crashes. This is never supported (and is of course expected

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-24 Thread Ronald S. Bultje
Hi, On Fri, Mar 24, 2017 at 9:15 PM, Michael Niedermayer wrote: > Repeatly starting a discussion when some patch comes up on a subject > but then failing to really reach a decission and failing to document > it and repeating the cycle over and over is not good +1.

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-24 Thread Michael Niedermayer
On Fri, Mar 24, 2017 at 10:16:42AM -0400, Ronald S. Bultje wrote: [...] > There is also the risk with the initial patch that compiling libavcodec > against a newer libavutil but then runtime linking it with another (older) > one would lead to crashes. This should not be possible the minor version

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-24 Thread Ronald S. Bultje
Hi, On Fri, Mar 24, 2017 at 10:05 AM, Clément Bœsch wrote: > On Fri, Mar 24, 2017 at 10:40:21AM +0100, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes #6255. > > > > Please comment, Carl Eugen > > > From 1c249440c62271565be12112f321ad9aa6a922fb Mon Sep 17 00:00:00 2001

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-24 Thread Clément Bœsch
On Fri, Mar 24, 2017 at 10:40:21AM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes #6255. > > Please comment, Carl Eugen > From 1c249440c62271565be12112f321ad9aa6a922fb Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos > Date: Fri, 24 Mar 2017 10:38:22 +0100 >

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-24 Thread wm4
On Fri, 24 Mar 2017 07:48:53 -0400 "Ronald S. Bultje" wrote: > Hi, > > On Fri, Mar 24, 2017 at 7:40 AM, Ronald S. Bultje > wrote: > > > Hi, > > > > On Fri, Mar 24, 2017 at 6:23 AM, Carl Eugen Hoyos > > wrote: > > > >> there are

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-24 Thread Ronald S. Bultje
Hi, On Fri, Mar 24, 2017 at 7:40 AM, Ronald S. Bultje wrote: > Hi, > > On Fri, Mar 24, 2017 at 6:23 AM, Carl Eugen Hoyos > wrote: > >> there are several similar cases there. > > > That is classically how ff_ symbols became public API. Please don't use >

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-24 Thread Ronald S. Bultje
Hi, On Fri, Mar 24, 2017 at 6:23 AM, Carl Eugen Hoyos wrote: > there are several similar cases there. That is classically how ff_ symbols became public API. Please don't use that argument ever again. Ronald ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-24 Thread wm4
On Fri, 24 Mar 2017 11:23:44 +0100 Carl Eugen Hoyos wrote: > 2017-03-24 10:59 GMT+01:00 wm4 : > > On Fri, 24 Mar 2017 10:40:21 +0100 > > Carl Eugen Hoyos wrote: > > > >> From 1c249440c62271565be12112f321ad9aa6a922fb Mon Sep 17

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-24 Thread Carl Eugen Hoyos
2017-03-24 10:59 GMT+01:00 wm4 : > On Fri, 24 Mar 2017 10:40:21 +0100 > Carl Eugen Hoyos wrote: > >> From 1c249440c62271565be12112f321ad9aa6a922fb Mon Sep 17 00:00:00 2001 >> From: Carl Eugen Hoyos >> Date: Fri, 24 Mar 2017 10:38:22

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-24 Thread wm4
On Fri, 24 Mar 2017 10:40:21 +0100 Carl Eugen Hoyos wrote: > From 1c249440c62271565be12112f321ad9aa6a922fb Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos > Date: Fri, 24 Mar 2017 10:38:22 +0100 > Subject: [PATCH] lavc/h264_ps: Check that chroma_location is

[FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-24 Thread Carl Eugen Hoyos
Hi! Attached patch fixes #6255. Please comment, Carl Eugen From 1c249440c62271565be12112f321ad9aa6a922fb Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 24 Mar 2017 10:38:22 +0100 Subject: [PATCH] lavc/h264_ps: Check that chroma_location is within limits. Fixes