Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-19 Thread James Zern
On Fri, Feb 19, 2016 at 12:17 PM, Carl Eugen Hoyos wrote: > Could you comment on ticket #3271 (is alpha possible in > vp9?) and #4105? I added some notes. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-19 Thread Carl Eugen Hoyos
James Zern google.com> writes: > >> I think his point is that the decoder always outputs LE, > >> and this change is therefor incorrect? > > > > Don't you agree that this is highly unlikely? > > (I mean by looking at the code, not because I claim it.) > > > > Yes, you're correct, I wasn't

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-19 Thread James Zern
On Fri, Feb 19, 2016 at 12:43 AM, Carl Eugen Hoyos wrote: > Hendrik Leppkes gmail.com> writes: > >> On Fri, Feb 19, 2016 at 8:47 AM, James Zern wrote: >> > On Thu, Feb 18, 2016 at 11:40 PM, Carl Eugen Hoyos wrote: >> >> On Friday 19 February 2016 07:59:37 am James Zern wrote:

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour?spaces

2016-02-19 Thread Michael Niedermayer
On Fri, Feb 19, 2016 at 08:42:29AM +, Carl Eugen Hoyos wrote: > James Zern google.com> writes: > > > On Fri, Feb 19, 2016 at 12:00 AM, Carl Eugen Hoyos wrote: > > > James Zern google.com> writes: > > > > > >> On Thu, Feb 18, 2016 at 11:40 PM, Carl Eugen Hoyos wrote: > > >> > On Friday 19

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-19 Thread Carl Eugen Hoyos
Hendrik Leppkes gmail.com> writes: > On Fri, Feb 19, 2016 at 8:47 AM, James Zern wrote: > > On Thu, Feb 18, 2016 at 11:40 PM, Carl Eugen Hoyos wrote: > >> On Friday 19 February 2016 07:59:37 am James Zern wrote: > >> > >>> The decoder won't change when built on a big-endian > >>> platform, so I

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-19 Thread Carl Eugen Hoyos
James Zern google.com> writes: > On Fri, Feb 19, 2016 at 12:00 AM, Carl Eugen Hoyos wrote: > > James Zern google.com> writes: > > > >> On Thu, Feb 18, 2016 at 11:40 PM, Carl Eugen Hoyos wrote: > >> > On Friday 19 February 2016 07:59:37 am James Zern wrote: > >> > > >> >> The decoder won't

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-19 Thread Carl Eugen Hoyos
Nicolas George nsup.org> writes: > Le primidi 1er ventôse, an CCXXIV, Carl Eugen Hoyos a écrit : > > Please comment, Carl Eugen > > Just a quick nit: please be careful about hugh bitdepth vs. high bitrate. I hopefully won't forget: Thank you for pointing this out! Carl Eugen

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-19 Thread Hendrik Leppkes
On Fri, Feb 19, 2016 at 8:47 AM, James Zern wrote: > On Thu, Feb 18, 2016 at 11:40 PM, Carl Eugen Hoyos wrote: >> On Friday 19 February 2016 07:59:37 am James Zern wrote: >> >>> The decoder won't change when built on a big-endian platform, so I don't >>> think

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-19 Thread Nicolas George
Le primidi 1er ventôse, an CCXXIV, Carl Eugen Hoyos a écrit : > Please comment, Carl Eugen Just a quick nit: please be careful about hugh bitdepth vs. high bitrate. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-19 Thread Carl Eugen Hoyos
James Zern google.com> writes: > On Thu, Feb 18, 2016 at 11:40 PM, Carl Eugen Hoyos > On Friday 19 February 2016 07:59:37 am James Zern wrote: > > > >> The decoder won't change when built on a big-endian > >> platform, so I don't think this is correct. > > > > New patch attached. > > Sorry, I

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-18 Thread James Zern
On Thu, Feb 18, 2016 at 11:40 PM, Carl Eugen Hoyos wrote: > On Friday 19 February 2016 07:59:37 am James Zern wrote: > >> The decoder won't change when built on a big-endian platform, so I don't >> think this is correct. > > New patch attached. > Sorry, I meant all of it, high

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-18 Thread Carl Eugen Hoyos
On Friday 19 February 2016 07:59:37 am James Zern wrote: > The decoder won't change when built on a big-endian platform, so I don't > think this is correct. New patch attached. Thank you, Carl Eugen diff --git a/libavcodec/libvpx.c b/libavcodec/libvpx.c index a60d186..1e7010b 100644 ---

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-18 Thread James Zern
Hi, On Thu, Feb 18, 2016 at 3:30 PM, Carl Eugen Hoyos wrote: > Please comment, Carl Eugen > diff --git a/libavcodec/libvpx.c b/libavcodec/libvpx.c > index a60d186..1e7010b 100644 > --- a/libavcodec/libvpx.c > +++ b/libavcodec/libvpx.c > @@ -46,14 +46,14 @@ static const enum

[FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-18 Thread Carl Eugen Hoyos
Please comment, Carl Eugen diff --git a/libavcodec/libvpx.c b/libavcodec/libvpx.c index a60d186..1e7010b 100644 --- a/libavcodec/libvpx.c +++ b/libavcodec/libvpx.c @@ -46,14 +46,14 @@ static const enum AVPixelFormat vp9_pix_fmts_highbd[] = { AV_PIX_FMT_YUV422P, AV_PIX_FMT_YUV440P,