[FFmpeg-devel] [PATCH]lavf/riff: Do not use a rogue twocc for adpcm_swf

Hi! Attached patch "fixes" ticket #5829, I am happy if a better solution can be found. Please comment, Carl Eugen From 69d62cac34908fb2a37e37ef1b03b565f2b4ae78 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 12 Sep 2016 12:42:33 +0200 Subject: [PATCH] lavf/riff: Do not use a rogue tw

Re: [FFmpeg-devel] [PATCH]lavf/riff: Do not use a rogue twocc for adpcm_swf

2016-09-12 12:52 GMT+02:00 Carl Eugen Hoyos : > Attached patch "fixes" ticket #5829, I am happy if a better > solution can be found. Ping. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavf/riff: Do not use a rogue twocc for adpcm_swf

Hi, On Wed, Sep 14, 2016 at 12:01 PM, Carl Eugen Hoyos wrote: > 2016-09-12 12:52 GMT+02:00 Carl Eugen Hoyos : > > > Attached patch "fixes" ticket #5829, I am happy if a better > > solution can be found. > > Ping. What makes you believe this is not the right solution? As in: why was the rogue t

Re: [FFmpeg-devel] [PATCH]lavf/riff: Do not use a rogue twocc for adpcm_swf

Hi! 2016-09-14 18:05 GMT+02:00 Ronald S. Bultje : > > On Wed, Sep 14, 2016 at 12:01 PM, Carl Eugen Hoyos wrote: > >> 2016-09-12 12:52 GMT+02:00 Carl Eugen Hoyos : >> >> > Attached patch "fixes" ticket #5829, I am happy if a better >> > solution can be found. > What makes you believe this is not t

Re: [FFmpeg-devel] [PATCH]lavf/riff: Do not use a rogue twocc for adpcm_swf

Hi, On Wed, Sep 14, 2016 at 12:29 PM, Carl Eugen Hoyos wrote: > Hi! > > 2016-09-14 18:05 GMT+02:00 Ronald S. Bultje : > > > > On Wed, Sep 14, 2016 at 12:01 PM, Carl Eugen Hoyos wrote: > > > >> 2016-09-12 12:52 GMT+02:00 Carl Eugen Hoyos : > >> > >> > Attached patch "fixes" ticket #5829, I am hap

Re: [FFmpeg-devel] [PATCH]lavf/riff: Do not use a rogue twocc for adpcm_swf

2016-09-14 19:21 GMT+02:00 Ronald S. Bultje : [...] >> I wondered if somebody can easily fix muxing / demuxing which >> could be considered a nicer solution. > > You mean remuxing (with -c:a copy) of swf files? There (also) is an encoder... Carl Eugen ___

Re: [FFmpeg-devel] [PATCH]lavf/riff: Do not use a rogue twocc for adpcm_swf

Hi, On Wed, Sep 14, 2016 at 1:46 PM, Carl Eugen Hoyos wrote: > 2016-09-14 19:21 GMT+02:00 Ronald S. Bultje : > > [...] > > >> I wondered if somebody can easily fix muxing / demuxing which > >> could be considered a nicer solution. > > > > You mean remuxing (with -c:a copy) of swf files? > > Ther

Re: [FFmpeg-devel] [PATCH]lavf/riff: Do not use a rogue twocc for adpcm_swf

Hi! 2016-09-14 22:50 GMT+02:00 Ronald S. Bultje : > > On Wed, Sep 14, 2016 at 1:46 PM, Carl Eugen Hoyos wrote: > >> 2016-09-14 19:21 GMT+02:00 Ronald S. Bultje : >> >> I wondered if somebody can easily fix muxing / demuxing which >> >> could be considered a nicer solution. >> > >> > You mean remu

Re: [FFmpeg-devel] [PATCH]lavf/riff: Do not use a rogue twocc for adpcm_swf

On Mon, Sep 12, 2016 at 12:52:49PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch "fixes" ticket #5829, I am happy if a better > solution can be found. > > Please comment, Carl Eugen > riff.c |1 - > 1 file changed, 1 deletion(-) > 6113805920f6fb418635029f2f600fcfe1c3fa88 > 0001

Re: [FFmpeg-devel] [PATCH]lavf/riff: Do not use a rogue twocc for adpcm_swf

2016-09-15 15:42 GMT+02:00 Michael Niedermayer : >> -{ AV_CODEC_ID_ADPCM_SWF, ('S' << 8) + 'F' }, >> /* HACK/FIXME: Does Vorbis in WAV/AVI have an (in)official ID? */ >> { AV_CODEC_ID_VORBIS, ('V' << 8) + 'o' }, >> { AV_CODEC_ID_NONE, 0 }, > > does this affect

Re: [FFmpeg-devel] [PATCH]lavf/riff: Do not use a rogue twocc for adpcm_swf

On Thu, Sep 15, 2016 at 03:47:49PM +0200, Carl Eugen Hoyos wrote: > 2016-09-15 15:42 GMT+02:00 Michael Niedermayer : > >> -{ AV_CODEC_ID_ADPCM_SWF, ('S' << 8) + 'F' }, > >> /* HACK/FIXME: Does Vorbis in WAV/AVI have an (in)official ID? */ > >> { AV_CODEC_ID_VORBIS, ('V'

Re: [FFmpeg-devel] [PATCH]lavf/riff: Do not use a rogue twocc for adpcm_swf

2016-09-15 20:48 GMT+02:00 Michael Niedermayer : > On Thu, Sep 15, 2016 at 03:47:49PM +0200, Carl Eugen Hoyos wrote: >> 2016-09-15 15:42 GMT+02:00 Michael Niedermayer : >> >> -{ AV_CODEC_ID_ADPCM_SWF, ('S' << 8) + 'F' }, >> >> /* HACK/FIXME: Does Vorbis in WAV/AVI have an (in)officia

Re: [FFmpeg-devel] [PATCH]lavf/riff: Do not use a rogue twocc for adpcm_swf

On Sat, Sep 17, 2016 at 03:06:57PM +0200, Carl Eugen Hoyos wrote: > 2016-09-15 20:48 GMT+02:00 Michael Niedermayer : > > On Thu, Sep 15, 2016 at 03:47:49PM +0200, Carl Eugen Hoyos wrote: > >> 2016-09-15 15:42 GMT+02:00 Michael Niedermayer : > >> >> -{ AV_CODEC_ID_ADPCM_SWF, ('S' << 8) + '

Re: [FFmpeg-devel] [PATCH]lavf/riff: Do not use a rogue twocc for adpcm_swf

2016-09-17 18:26 GMT+02:00 Michael Niedermayer : >> >> Is it possible to fix adpcm_swf in wav? >> > >> > maybe if block_align is set (and is constant) >> >> Attached fixes encoding, decoding still has the issue >> that the decoder doesn't like more than one packet. >> (Iiuc, it works if I limit th

Re: [FFmpeg-devel] [PATCH]lavf/riff: Do not use a rogue twocc for adpcm_swf

On 9/17/16, Michael Niedermayer wrote: > On Sat, Sep 17, 2016 at 03:06:57PM +0200, Carl Eugen Hoyos wrote: >> 2016-09-15 20:48 GMT+02:00 Michael Niedermayer : >> > On Thu, Sep 15, 2016 at 03:47:49PM +0200, Carl Eugen Hoyos wrote: >> >> 2016-09-15 15:42 GMT+02:00 Michael Niedermayer >> >> : >> >> >

Re: [FFmpeg-devel] [PATCH]lavf/riff: Do not use a rogue twocc for adpcm_swf

On Sun, Sep 18, 2016 at 01:00:01AM +0200, Paul B Mahol wrote: > On 9/17/16, Michael Niedermayer wrote: > > On Sat, Sep 17, 2016 at 03:06:57PM +0200, Carl Eugen Hoyos wrote: > >> 2016-09-15 20:48 GMT+02:00 Michael Niedermayer : > >> > On Thu, Sep 15, 2016 at 03:47:49PM +0200, Carl Eugen Hoyos wrote