Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-29 Thread Clément Bœsch
Patchset pushed with av_fourcc2str() macro name. [...] -- Clément B. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-29 Thread Clément Bœsch
On Wed, Mar 29, 2017 at 09:56:14AM +0200, Clément Bœsch wrote: > On Wed, Mar 29, 2017 at 09:52:51AM +0200, Carl Eugen Hoyos wrote: > > 2017-03-29 9:43 GMT+02:00 Clément Bœsch : > > > On Wed, Mar 29, 2017 at 09:31:57AM +0200, Carl Eugen Hoyos wrote: > > >> 2017-03-28 17:31 GMT+02:00 Clément Bœsch :

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-29 Thread Clément Bœsch
On Wed, Mar 29, 2017 at 09:52:51AM +0200, Carl Eugen Hoyos wrote: > 2017-03-29 9:43 GMT+02:00 Clément Bœsch : > > On Wed, Mar 29, 2017 at 09:31:57AM +0200, Carl Eugen Hoyos wrote: > >> 2017-03-28 17:31 GMT+02:00 Clément Bœsch : > >> > On Mon, Mar 27, 2017 at 09:51:54AM +0200, Clément Bœsch wrote: >

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-29 Thread Carl Eugen Hoyos
2017-03-29 9:43 GMT+02:00 Clément Bœsch : > On Wed, Mar 29, 2017 at 09:31:57AM +0200, Carl Eugen Hoyos wrote: >> 2017-03-28 17:31 GMT+02:00 Clément Bœsch : >> > On Mon, Mar 27, 2017 at 09:51:54AM +0200, Clément Bœsch wrote: >> >> --- >> >> doc/APIchanges | 4 >> >> libavutil/avutil.h |

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-29 Thread Clément Bœsch
On Wed, Mar 29, 2017 at 09:31:57AM +0200, Carl Eugen Hoyos wrote: > 2017-03-28 17:31 GMT+02:00 Clément Bœsch : > > On Mon, Mar 27, 2017 at 09:51:54AM +0200, Clément Bœsch wrote: > >> --- > >> doc/APIchanges | 4 > >> libavutil/avutil.h | 14 ++ > >> libavutil/utils.c | 21

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-29 Thread Carl Eugen Hoyos
2017-03-28 17:31 GMT+02:00 Clément Bœsch : > On Mon, Mar 27, 2017 at 09:51:54AM +0200, Clément Bœsch wrote: >> --- >> doc/APIchanges | 4 >> libavutil/avutil.h | 14 ++ >> libavutil/utils.c | 21 + >> libavutil/version.h | 2 +- >> 4 files changed, 40

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-28 Thread Tobias Rapp
On 28.03.2017 10:19, Clément Bœsch wrote: On Tue, Mar 28, 2017 at 12:47:39AM +0200, Alexander Strasser wrote: [...] + +#define av_4cc2str(fourcc) av_fourcc_make_string((char[AV_FOURCC_MAX_STRING_SIZE]){0}, fourcc) Did your write it as 4cc2str to make the name shorter? I guess fourcc2str is mo

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-28 Thread Matthias Hunstock
Am 28.03.2017 um 12:59 schrieb Clément Bœsch: > I didn't rename the prototype or the macro so it doesn't need any update, > or am I missing something? No you don't.. I did - sorry! Matthias ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ff

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-28 Thread Alexander Strasser
On 2017-03-28 18:16 +0200, Clément Bœsch wrote: > On Tue, Mar 28, 2017 at 06:12:14PM +0200, Michael Niedermayer wrote: > > On Tue, Mar 28, 2017 at 10:19:46AM +0200, Clément Bœsch wrote: > > [...] > > > diff --git a/libavutil/utils.c b/libavutil/utils.c > > > index 36e4dd5fdb..29f2746338 100644 > >

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-28 Thread Alexander Strasser
On 2017-03-28 10:19 +0200, Clément Bœsch wrote: > On Tue, Mar 28, 2017 at 12:47:39AM +0200, Alexander Strasser wrote: > [...] > > > +#define AV_FOURCC_MAX_STRING_SIZE 32 > > > > Should be fine, though I don't know how you came up with this max size in > > particular. > > > > IIRC the actual max

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-28 Thread Clément Bœsch
On Tue, Mar 28, 2017 at 06:12:14PM +0200, Michael Niedermayer wrote: > On Tue, Mar 28, 2017 at 10:19:46AM +0200, Clément Bœsch wrote: > [...] > > diff --git a/libavutil/utils.c b/libavutil/utils.c > > index 36e4dd5fdb..29f2746338 100644 > > --- a/libavutil/utils.c > > +++ b/libavutil/utils.c > > @@

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-28 Thread Michael Niedermayer
On Tue, Mar 28, 2017 at 10:19:46AM +0200, Clément Bœsch wrote: [...] > diff --git a/libavutil/utils.c b/libavutil/utils.c > index 36e4dd5fdb..29f2746338 100644 > --- a/libavutil/utils.c > +++ b/libavutil/utils.c > @@ -121,6 +121,29 @@ unsigned av_int_list_length_for_size(unsigned elsize, > ret

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-28 Thread Clément Bœsch
On Mon, Mar 27, 2017 at 09:51:54AM +0200, Clément Bœsch wrote: > --- > doc/APIchanges | 4 > libavutil/avutil.h | 14 ++ > libavutil/utils.c | 21 + > libavutil/version.h | 2 +- > 4 files changed, 40 insertions(+), 1 deletion(-) > I'll start pushin

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-28 Thread Clément Bœsch
On Tue, Mar 28, 2017 at 12:57:52PM +0200, Matthias Hunstock wrote: > Am 28.03.2017 um 10:19 schrieb Clément Bœsch: > > But you're right on all your comments so I just adjusted the function. See > > patch attached. > > Did you also update the deprecation notice in [PATCH 02/10]? > I didn't rename

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-28 Thread Matthias Hunstock
Am 28.03.2017 um 10:19 schrieb Clément Bœsch: > But you're right on all your comments so I just adjusted the function. See > patch attached. Did you also update the deprecation notice in [PATCH 02/10]? Matthias ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-28 Thread Clément Bœsch
On Tue, Mar 28, 2017 at 12:47:39AM +0200, Alexander Strasser wrote: [...] > > +#define AV_FOURCC_MAX_STRING_SIZE 32 > > Should be fine, though I don't know how you came up with this max size in > particular. > IIRC the actual maximum is 21 characters, I just took the closest superior power of t

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-27 Thread Alexander Strasser
Hi Clément, I think your idea of introducing this function and the convenience macro is good. Below are some comments, feel free to ignore. On 2017-03-27 09:51 +0200, Clément Bœsch wrote: > --- > doc/APIchanges | 4 > libavutil/avutil.h | 14 ++ > libavutil/utils.c |

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-27 Thread Clément Bœsch
On Mon, Mar 27, 2017 at 11:16:24AM -0300, James Almer wrote: > On 3/27/2017 4:51 AM, Clément Bœsch wrote: > > --- > > doc/APIchanges | 4 > > libavutil/avutil.h | 14 ++ > > libavutil/utils.c | 21 + > > libavutil/version.h | 2 +- > > 4 files changed

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-27 Thread James Almer
On 3/27/2017 4:51 AM, Clément Bœsch wrote: > --- > doc/APIchanges | 4 > libavutil/avutil.h | 14 ++ > libavutil/utils.c | 21 + > libavutil/version.h | 2 +- > 4 files changed, 40 insertions(+), 1 deletion(-) > > diff --git a/doc/APIchanges b/doc/AP

[FFmpeg-devel] [PATCH 01/10] lavu: add av_fourcc_make_string() and av_4cc2str()

2017-03-27 Thread Clément Bœsch
--- doc/APIchanges | 4 libavutil/avutil.h | 14 ++ libavutil/utils.c | 21 + libavutil/version.h | 2 +- 4 files changed, 40 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 6aaa9adceb..4736e3e6fc 100644 --- a/doc/APIc