On Mon, 8 Jan 2018, Devin Heitmueller wrote:
Hook in libklvanc and use it for output of EIA-708 captions over
SDI. The bulk of this patch is just general support for ancillary
data for the Decklink SDI module - the real work for construction
of the EIA-708 CDP and VANC line construction is do
On Wed, Jan 10, 2018 at 09:11:35 -0500, Devin Heitmueller wrote:
> For loop declaration has been part of the C standard since C99.
I'm just quoting other similar discussions on this list. This has been
a topic several (hundred? ;-)) times the last few months. It peaked in
this discussion which was
Hello Moritz,
> On Wed, Jan 10, 2018 at 14:29:43 +0100, Moritz Barsnick wrote:
>>> +for (size_t i = 0; i < cc_count; i++) {
>> Declare i outside the clause.
>>> +for (int i = 0; i < vanc_lines.num_lines; i++) {
>> Same here.
>
> Sorry, this rule may not apply to C++ files, as it's par
On Wed, Jan 10, 2018 at 14:29:43 +0100, Moritz Barsnick wrote:
> > +for (size_t i = 0; i < cc_count; i++) {
> Declare i outside the clause.
> > +for (int i = 0; i < vanc_lines.num_lines; i++) {
> Same here.
Sorry, this rule may not apply to C++ files, as it's part of all C++
standards
On Mon, Jan 08, 2018 at 20:16:48 -0500, Devin Heitmueller wrote:
> +if (ctx->supports_vanc == 0 ||
> ctx->dlo->DoesSupportVideoMode(ctx->bmd_mode, ctx->raw_format,
In other places you (or the DeckLink code) use
if (!ctx->supports_vanc || [...]
which I believe is preferred.
> +if
Hook in libklvanc and use it for output of EIA-708 captions over
SDI. The bulk of this patch is just general support for ancillary
data for the Decklink SDI module - the real work for construction
of the EIA-708 CDP and VANC line construction is done by libklvanc.
Libklvanc can be found at: https
