Re: [FFmpeg-devel] [PATCH 01/17] avformat/mxfenc: Auto-insert h264_mp4toannexb BSF if needed

2021-11-10 Thread Tomas Härdin
ons 2021-11-10 klockan 14:21 +0100 skrev Andreas Rheinhardt: > Tomas Härdin: > > tis 2021-11-09 klockan 22:07 +0100 skrev Andreas Rheinhardt: > > > Tomas Härdin: > > > > tis 2021-11-09 klockan 18:34 +0100 skrev Andreas Rheinhardt: > > > > > The mxf and mxf_opatom muxer expect H.264 in Annex B

Re: [FFmpeg-devel] [PATCH 01/17] avformat/mxfenc: Auto-insert h264_mp4toannexb BSF if needed

2021-11-10 Thread Andreas Rheinhardt
Tomas Härdin: > tis 2021-11-09 klockan 22:07 +0100 skrev Andreas Rheinhardt: >> Tomas Härdin: >>> tis 2021-11-09 klockan 18:34 +0100 skrev Andreas Rheinhardt: The mxf and mxf_opatom muxer expect H.264 in Annex B format. Signed-off-by: Andreas Rheinhardt --- The check

Re: [FFmpeg-devel] [PATCH 01/17] avformat/mxfenc: Auto-insert h264_mp4toannexb BSF if needed

2021-11-09 Thread Tomas Härdin
tis 2021-11-09 klockan 22:07 +0100 skrev Andreas Rheinhardt: > Tomas Härdin: > > tis 2021-11-09 klockan 18:34 +0100 skrev Andreas Rheinhardt: > > > The mxf and mxf_opatom muxer expect H.264 in Annex B format. > > > > > > Signed-off-by: Andreas Rheinhardt > > > > > > --- > > > The check here is

Re: [FFmpeg-devel] [PATCH 01/17] avformat/mxfenc: Auto-insert h264_mp4toannexb BSF if needed

2021-11-09 Thread Andreas Rheinhardt
Tomas Härdin: > tis 2021-11-09 klockan 18:34 +0100 skrev Andreas Rheinhardt: >> The mxf and mxf_opatom muxer expect H.264 in Annex B format. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> The check here is taken from mpegtsenc. > > You didn't think to make both muxers share code instead of

Re: [FFmpeg-devel] [PATCH 01/17] avformat/mxfenc: Auto-insert h264_mp4toannexb BSF if needed

2021-11-09 Thread Tomas Härdin
tis 2021-11-09 klockan 18:34 +0100 skrev Andreas Rheinhardt: > The mxf and mxf_opatom muxer expect H.264 in Annex B format. > > Signed-off-by: Andreas Rheinhardt > --- > The check here is taken from mpegtsenc. You didn't think to make both muxers share code instead of copy- pasting? /Tomas

Re: [FFmpeg-devel] [PATCH 01/17] avformat/mxfenc: Auto-insert h264_mp4toannexb BSF if needed

2021-11-09 Thread James Almer
On 11/9/2021 2:34 PM, Andreas Rheinhardt wrote: The mxf and mxf_opatom muxer expect H.264 in Annex B format. Amazing that nobody noticed this until now. Guess remuxing from mp4/mkv to mxf is not a common scenario. LGTM, just tested a quick remux and without the bsf it just fails.

[FFmpeg-devel] [PATCH 01/17] avformat/mxfenc: Auto-insert h264_mp4toannexb BSF if needed

2021-11-09 Thread Andreas Rheinhardt
The mxf and mxf_opatom muxer expect H.264 in Annex B format. Signed-off-by: Andreas Rheinhardt --- The check here is taken from mpegtsenc. libavformat/mxfenc.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index