Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-27 Thread Jean-Baptiste Kempf
On Thu, Feb 27, 2020, at 18:33, Michael Niedermayer wrote: > > > I agree that the current QP code (not feature) should be deprecated as it > > > does not work with newer codec. > > > But before removing the deprecated code, it will be nice to have the same > > > feature available with a newer API,

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-27 Thread Michael Niedermayer
On Thu, Feb 27, 2020 at 12:30:22PM +0100, Anton Khirnov wrote: > Quoting Thierry Foucu (2020-02-26 19:04:57) > > First of all, thanks for trying to clean up deprecated API > > > > On Wed, Feb 26, 2020 at 6:03 AM Jean-Baptiste Kempf > > wrote: > > > > > Yo, > > > > > > On Wed, Feb 26, 2020, at 1

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-27 Thread Jean-Baptiste Kempf
On Thu, Feb 27, 2020, at 12:30, Anton Khirnov wrote: > > Today, for example, when we want to visualize QP, we use libavcodec to > > decode the frame, use another piece of code to extract the QP and overlay > > both of them. This is almost (and i say ALMOST) decoding the frame twice. > > (BTW, we ca

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-27 Thread Anton Khirnov
Quoting Thierry Foucu (2020-02-26 19:04:57) > First of all, thanks for trying to clean up deprecated API > > On Wed, Feb 26, 2020 at 6:03 AM Jean-Baptiste Kempf wrote: > > > Yo, > > > > On Wed, Feb 26, 2020, at 14:27, Thilo Borgmann wrote: > > > > The patch in your link is not using this API. Pr

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-26 Thread Thierry Foucu
First of all, thanks for trying to clean up deprecated API On Wed, Feb 26, 2020 at 6:03 AM Jean-Baptiste Kempf wrote: > Yo, > > On Wed, Feb 26, 2020, at 14:27, Thilo Borgmann wrote: > > > The patch in your link is not using this API. Precisely because this > API > > > is inadequate for anything

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-26 Thread Thilo Borgmann
Am 26.02.20 um 16:26 schrieb Jean-Baptiste Kempf: > On Wed, Feb 26, 2020, at 15:46, Paul B Mahol wrote: >> On 2/26/20, Jean-Baptiste Kempf wrote: >>> Yo, >>> >>> On Wed, Feb 26, 2020, at 14:27, Thilo Borgmann wrote: > The patch in your link is not using this API. Precisely because this API >>>

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-26 Thread Jean-Baptiste Kempf
On Wed, Feb 26, 2020, at 15:46, Paul B Mahol wrote: > On 2/26/20, Jean-Baptiste Kempf wrote: > > Yo, > > > > On Wed, Feb 26, 2020, at 14:27, Thilo Borgmann wrote: > >> > The patch in your link is not using this API. Precisely because this API > >> > is inadequate for anything newer than MPEG4 ASP.

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-26 Thread Paul B Mahol
On 2/26/20, Jean-Baptiste Kempf wrote: > Yo, > > On Wed, Feb 26, 2020, at 14:27, Thilo Borgmann wrote: >> > The patch in your link is not using this API. Precisely because this API >> > is inadequate for anything newer than MPEG4 ASP. If anything, it's an >> > additional argument in favor of my pa

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-26 Thread Jean-Baptiste Kempf
Yo, On Wed, Feb 26, 2020, at 14:27, Thilo Borgmann wrote: > > The patch in your link is not using this API. Precisely because this API > > is inadequate for anything newer than MPEG4 ASP. If anything, it's an > > additional argument in favor of my patches. > > My actual point about that patch was

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-26 Thread Thilo Borgmann
Am 25.02.20 um 11:28 schrieb Anton Khirnov: > Quoting Thilo Borgmann (2020-02-24 23:07:48) >> Am 24.02.20 um 22:41 schrieb Lou Logan: >>> On Mon, Feb 24, 2020, at 3:37 AM, Anton Khirnov wrote: It fundamentally depends on an API that has been deprecated for five years, has seen no commits

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-25 Thread Nicolas George
Anton Khirnov (12020-02-25): > So I believe all code needs > continued justification for its existence - not just "it was added in > the past so it stays in forever". Note that I'm not saying it needs to > be mainstream or very popular - I am fine with ob

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-25 Thread Anton Khirnov
Quoting Thilo Borgmann (2020-02-24 23:07:48) > Am 24.02.20 um 22:41 schrieb Lou Logan: > > On Mon, Feb 24, 2020, at 3:37 AM, Anton Khirnov wrote: > >> It fundamentally depends on an API that has been deprecated for five > >> years, has seen no commits since that time and is of highly dubious > >> u

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-25 Thread Paul B Mahol
On 2/25/20, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-02-24 20:15:43) >> On Mon, Feb 24, 2020 at 03:54:45PM +0100, Anton Khirnov wrote: >> > Quoting Carl Eugen Hoyos (2020-02-24 13:50:57) >> > > Am Mo., 24. Feb. 2020 um 13:40 Uhr schrieb Anton Khirnov >> > > : >> > > > >> > > > It f

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-25 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-02-24 20:15:43) > On Mon, Feb 24, 2020 at 03:54:45PM +0100, Anton Khirnov wrote: > > Quoting Carl Eugen Hoyos (2020-02-24 13:50:57) > > > Am Mo., 24. Feb. 2020 um 13:40 Uhr schrieb Anton Khirnov > > > : > > > > > > > > It fundamentally depends on an API that has b

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread Vittorio Giovara
On Mon, Feb 24, 2020 at 5:07 PM Thilo Borgmann wrote: > Am 24.02.20 um 22:41 schrieb Lou Logan: > > On Mon, Feb 24, 2020, at 3:37 AM, Anton Khirnov wrote: > >> It fundamentally depends on an API that has been deprecated for five > >> years, has seen no commits since that time and is of highly dub

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread Hendrik Leppkes
On Mon, Feb 24, 2020 at 11:08 PM Thilo Borgmann wrote: > And how comes, if Michael's investigation, that all of this is based on use > of _a function_ that is deprecated instead of direct access of AVFrame's > fields is the cause of all of this? > The entire functionality is deprecated, that th

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread Thilo Borgmann
Am 24.02.20 um 22:41 schrieb Lou Logan: > On Mon, Feb 24, 2020, at 3:37 AM, Anton Khirnov wrote: >> It fundamentally depends on an API that has been deprecated for five >> years, has seen no commits since that time and is of highly dubious >> usefulness. >> --- >> doc/filters.texi| 32

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread Lou Logan
On Mon, Feb 24, 2020, at 3:37 AM, Anton Khirnov wrote: > It fundamentally depends on an API that has been deprecated for five > years, has seen no commits since that time and is of highly dubious > usefulness. > --- > doc/filters.texi| 32 --- > libavfilter/Makefile| 1 -

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread Michael Niedermayer
On Mon, Feb 24, 2020 at 03:54:45PM +0100, Anton Khirnov wrote: > Quoting Carl Eugen Hoyos (2020-02-24 13:50:57) > > Am Mo., 24. Feb. 2020 um 13:40 Uhr schrieb Anton Khirnov > > : > > > > > > It fundamentally depends on an API that has been deprecated for five > > > years, has seen no commits since

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread Paul B Mahol
On 2/24/20, Anton Khirnov wrote: > Quoting Paul B Mahol (2020-02-24 18:07:26) >> On 2/24/20, Anton Khirnov wrote: >> > Quoting Paul B Mahol (2020-02-24 17:02:52) >> >> On 2/24/20, James Almer wrote: >> >> > On Monday, February 24, 2020, Carl Eugen Hoyos >> >> > wrote: >> >> >> >> >> >> >> >> >>

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread Anton Khirnov
Quoting Paul B Mahol (2020-02-24 18:07:26) > On 2/24/20, Anton Khirnov wrote: > > Quoting Paul B Mahol (2020-02-24 17:02:52) > >> On 2/24/20, James Almer wrote: > >> > On Monday, February 24, 2020, Carl Eugen Hoyos > >> > wrote: > >> >> > >> >> > >> >> > >> >>> Am 24.02.2020 um 15:54 schrieb Ant

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread Paul B Mahol
On 2/24/20, Anton Khirnov wrote: > Quoting Paul B Mahol (2020-02-24 17:02:52) >> On 2/24/20, James Almer wrote: >> > On Monday, February 24, 2020, Carl Eugen Hoyos >> > wrote: >> >> >> >> >> >> >> >>> Am 24.02.2020 um 15:54 schrieb Anton Khirnov : >> >>> >> >>> Quoting Carl Eugen Hoyos (2020-02-

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Paul B Mahol > Sent: Monday, February 24, 2020 5:39 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp > > On

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread Anton Khirnov
Quoting Paul B Mahol (2020-02-24 13:56:56) > Filter should not be removed, it should use qp via frame side data. For what purpose? I am yet to hear about any valid use case for this filter. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ff

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread Anton Khirnov
Quoting Soft Works (2020-02-24 17:13:54) > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Anton Khirnov > > Sent: Monday, February 24, 2020 3:55 PM > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subje

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread Anton Khirnov
Quoting Paul B Mahol (2020-02-24 17:02:52) > On 2/24/20, James Almer wrote: > > On Monday, February 24, 2020, Carl Eugen Hoyos wrote: > >> > >> > >> > >>> Am 24.02.2020 um 15:54 schrieb Anton Khirnov : > >>> > >>> Quoting Carl Eugen Hoyos (2020-02-24 13:50:57) > > Am Mo., 24. Feb. 2020 um 13:

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread Paul B Mahol
On 2/24/20, Soft Works wrote: >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Anton Khirnov >> Sent: Monday, February 24, 2020 3:55 PM >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Subject: Re: [FFm

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Monday, February 24, 2020 3:55 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp > > Quoting Carl

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread Paul B Mahol
On 2/24/20, James Almer wrote: > On Monday, February 24, 2020, Carl Eugen Hoyos wrote: >> >> >> >>> Am 24.02.2020 um 15:54 schrieb Anton Khirnov : >>> >>> Quoting Carl Eugen Hoyos (2020-02-24 13:50:57) > Am Mo., 24. Feb. 2020 um 13:40 Uhr schrieb Anton Khirnov < > an...@khirnov.net>: > >>

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread James Almer
On Monday, February 24, 2020, Carl Eugen Hoyos wrote: > > > >> Am 24.02.2020 um 15:54 schrieb Anton Khirnov : >> >> Quoting Carl Eugen Hoyos (2020-02-24 13:50:57) Am Mo., 24. Feb. 2020 um 13:40 Uhr schrieb Anton Khirnov < an...@khirnov.net>: It fundamentally depends on an API that h

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread Carl Eugen Hoyos
> Am 24.02.2020 um 15:54 schrieb Anton Khirnov : > > Quoting Carl Eugen Hoyos (2020-02-24 13:50:57) >>> Am Mo., 24. Feb. 2020 um 13:40 Uhr schrieb Anton Khirnov >>> : >>> >>> It fundamentally depends on an API that has been deprecated for five >>> years, has seen no commits since that time an

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread Anton Khirnov
Quoting Carl Eugen Hoyos (2020-02-24 13:50:57) > Am Mo., 24. Feb. 2020 um 13:40 Uhr schrieb Anton Khirnov : > > > > It fundamentally depends on an API that has been deprecated for five > > years, has seen no commits since that time and is of highly dubious > > usefulness. > > Please explain how th

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread Paul B Mahol
Filter should not be removed, it should use qp via frame side data. On 2/24/20, Anton Khirnov wrote: > It fundamentally depends on an API that has been deprecated for five > years, has seen no commits since that time and is of highly dubious > usefulness. > --- > doc/filters.texi| 3

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread Carl Eugen Hoyos
Am Mo., 24. Feb. 2020 um 13:40 Uhr schrieb Anton Khirnov : > > It fundamentally depends on an API that has been deprecated for five > years, has seen no commits since that time and is of highly dubious > usefulness. Please explain how the removed functionality was replaced. Carl Eugen ___

[FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-24 Thread Anton Khirnov
It fundamentally depends on an API that has been deprecated for five years, has seen no commits since that time and is of highly dubious usefulness. --- doc/filters.texi| 32 --- libavfilter/Makefile| 1 - libavfilter/allfilters.c| 1 - libavfilter/vf_qp.c