Re: [FFmpeg-devel] [PATCH 04/10] avformat/mux: Fix leaks of uncoded frames on errors

2020-04-10 Thread Marton Balint
On Fri, 10 Apr 2020, Andreas Rheinhardt wrote: Marton Balint: On Tue, 31 Mar 2020, Andreas Rheinhardt wrote: If writing an uncoded frame fails at the preparatory steps of av_[interleaved_]write_frame(), the frame would be either not freed at all in case of av_write_frame() or would leak

Re: [FFmpeg-devel] [PATCH 04/10] avformat/mux: Fix leaks of uncoded frames on errors

2020-04-10 Thread Andreas Rheinhardt
Marton Balint: > > > On Tue, 31 Mar 2020, Andreas Rheinhardt wrote: > >> If writing an uncoded frame fails at the preparatory steps of >> av_[interleaved_]write_frame(), the frame would be either not freed >> at all in case of av_write_frame() or would leak when the fake packet >> would be

Re: [FFmpeg-devel] [PATCH 04/10] avformat/mux: Fix leaks of uncoded frames on errors

2020-03-31 Thread Marton Balint
On Tue, 31 Mar 2020, Andreas Rheinhardt wrote: If writing an uncoded frame fails at the preparatory steps of av_[interleaved_]write_frame(), the frame would be either not freed at all in case of av_write_frame() or would leak when the fake packet would be unreferenced like an ordinary packet.

[FFmpeg-devel] [PATCH 04/10] avformat/mux: Fix leaks of uncoded frames on errors

2020-03-31 Thread Andreas Rheinhardt
If writing an uncoded frame fails at the preparatory steps of av_[interleaved_]write_frame(), the frame would be either not freed at all in case of av_write_frame() or would leak when the fake packet would be unreferenced like an ordinary packet. There is also a memleak when the output format is