Re: [FFmpeg-devel] [PATCH 06/11] aacpsy: Add energy spread for each band

2015-06-29 Thread Rostislav Pehlivanov
Thanks for the suggestions. I did some tests and using active_lines seems to be a better measure of noise (the old spread_en[] used to increase linearly with every band and behaved more like a smooth low-pass filter for PNS values). I did some adjustments to it so the spectrums look fine and the ne

Re: [FFmpeg-devel] [PATCH 06/11] aacpsy: Add energy spread for each band

2015-06-29 Thread Claudio Freire
On Fri, Jun 26, 2015 at 5:16 PM, Rostislav Pehlivanov wrote: > +++ b/libavcodec/aacpsy.c > @@ -781,6 +781,7 @@ static void psy_3gpp_analyze_channel(FFPsyContext *ctx, > int channel, > > psy_band->threshold = band->thr; > psy_band->energy= band->energy; > +

Re: [FFmpeg-devel] [PATCH 06/11] aacpsy: Add energy spread for each band

2015-06-28 Thread Michael Niedermayer
On Sat, Jun 27, 2015 at 10:12:18PM -0300, Claudio Freire wrote: > LGTM applied thanks > > On Fri, Jun 26, 2015 at 5:16 PM, Rostislav Pehlivanov > wrote: > > -float distortion; > > -float perceptual_weight; > > Those are in fact in disuse. Thought I'd clarify. > __

Re: [FFmpeg-devel] [PATCH 06/11] aacpsy: Add energy spread for each band

2015-06-27 Thread Claudio Freire
LGTM On Fri, Jun 26, 2015 at 5:16 PM, Rostislav Pehlivanov wrote: > -float distortion; > -float perceptual_weight; Those are in fact in disuse. Thought I'd clarify. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman

[FFmpeg-devel] [PATCH 06/11] aacpsy: Add energy spread for each band

2015-06-26 Thread Rostislav Pehlivanov
This commit adds the energy spread to the struct for each band and removes 2 unused fields. distortion and perceptual_weight were not referenced in any file nor were they set to any value, so it was safe to remove them. The energy spread is currently only used in the aac psy model. It's defined