Re: [FFmpeg-devel] [PATCH 06/11] decklink: Add support for using libklvanc from within capture module

2018-01-12 Thread Devin Heitmueller
Hello Marton, Thank you for the feedback. Comments inline. >> +vanc_ctx->callback_context = &cb_ctx; >> +int ret = klvanc_packet_parse(vanc_ctx, lineNr, decoded_words, >> sizeof(decoded_words) / (sizeof(uint16_t))); > > A parity error also causes a negative return value? Or par

Re: [FFmpeg-devel] [PATCH 06/11] decklink: Add support for using libklvanc from within capture module

2018-01-12 Thread Marton Balint
On Mon, 8 Jan 2018, Devin Heitmueller wrote: Make use of libklvanc from within the DeckLink capture module, initially for EIA-708 and AFD. Support for other VANC types will come in subsequent patches. Incorporates feedback from Derek Buitenhuis , James Almer , and Aaron Levinson Signed-off

[FFmpeg-devel] [PATCH 06/11] decklink: Add support for using libklvanc from within capture module

2018-01-08 Thread Devin Heitmueller
Make use of libklvanc from within the DeckLink capture module, initially for EIA-708 and AFD. Support for other VANC types will come in subsequent patches. Incorporates feedback from Derek Buitenhuis , James Almer , and Aaron Levinson Signed-off-by: Devin Heitmueller --- libavdevice/decklink_