Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-17 Thread Michael Niedermayer
On Tue, Apr 17, 2018 at 11:16:36AM +0200, Hendrik Leppkes wrote: > On Tue, Apr 17, 2018 at 11:06 AM, Michael Niedermayer > wrote: > > On Tue, Apr 17, 2018 at 08:32:57AM +0300, Timo Teras wrote: > >> On Tue, 17 Apr 2018 01:02:43 +0200 > >> Michael Niedermayer wrote: > >> > >> > On Mon, Apr 16, 201

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-17 Thread Timo Teras
On Tue, 17 Apr 2018 11:06:58 +0200 Michael Niedermayer wrote: > On Tue, Apr 17, 2018 at 08:32:57AM +0300, Timo Teras wrote: > > See my earlier patch that changes it to report as "N/A". This is > > what > > i meant the function. Which cannot output N/A as it outputs a > "rational number" not a

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-17 Thread Nicolas George
Hendrik Leppkes (2018-04-17): > Internally we have been using 0/1 for undefined aspect ratios since > like forever, I'm not sure why that was chosen, but maybe to avoid an > accidental division by zero? There is the need for two special values: unknown/undefined and invalid/broken. Possible magic

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-17 Thread Hendrik Leppkes
On Tue, Apr 17, 2018 at 11:06 AM, Michael Niedermayer wrote: > On Tue, Apr 17, 2018 at 08:32:57AM +0300, Timo Teras wrote: >> On Tue, 17 Apr 2018 01:02:43 +0200 >> Michael Niedermayer wrote: >> >> > On Mon, Apr 16, 2018 at 07:56:34PM +0200, Marton Balint wrote: >> > > >> > > On Mon, 16 Apr 2018,

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-17 Thread Michael Niedermayer
On Tue, Apr 17, 2018 at 08:32:57AM +0300, Timo Teras wrote: > On Tue, 17 Apr 2018 01:02:43 +0200 > Michael Niedermayer wrote: > > > On Mon, Apr 16, 2018 at 07:56:34PM +0200, Marton Balint wrote: > > > > > > On Mon, 16 Apr 2018, Timo Teras wrote: > > > > > > >On Sun, 15 Apr 2018 16:42:01 +0200

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-16 Thread Tobias Rapp
On 17.04.2018 07:32, Timo Teras wrote: [...] Do note that calculating the reduced DAR requires some mathematics which may not be simple to do from e.g. shell or simple scripting languages. This is the primary reason why I was hoping ffprobe to do this for me. Would it be acceptable to print th

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-16 Thread Timo Teras
On Tue, 17 Apr 2018 01:02:43 +0200 Michael Niedermayer wrote: > On Mon, Apr 16, 2018 at 07:56:34PM +0200, Marton Balint wrote: > > > > On Mon, 16 Apr 2018, Timo Teras wrote: > > > > >On Sun, 15 Apr 2018 16:42:01 +0200 (CEST) > > >Marton Balint wrote: > > > > > >>On Sun, 15 Apr 2018, Timo T

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-16 Thread Michael Niedermayer
On Mon, Apr 16, 2018 at 07:56:34PM +0200, Marton Balint wrote: > > On Mon, 16 Apr 2018, Timo Teras wrote: > > >On Sun, 15 Apr 2018 16:42:01 +0200 (CEST) > >Marton Balint wrote: > > > >>On Sun, 15 Apr 2018, Timo Teräs wrote: > >> > >>> Calculate DAR with assumed SAR 1:1 when SAR is undefined. Sam

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-16 Thread Marton Balint
On Mon, 16 Apr 2018, Timo Teras wrote: On Sun, 15 Apr 2018 16:42:01 +0200 (CEST) Marton Balint wrote: On Sun, 15 Apr 2018, Timo Teräs wrote: > Calculate DAR with assumed SAR 1:1 when SAR is undefined. Same > assumption is done in ffplay to create the play window. Usually > DAR is more usefu

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-16 Thread Michael Niedermayer
On Mon, Apr 16, 2018 at 09:06:55AM +0300, Timo Teras wrote: > On Sun, 15 Apr 2018 16:42:01 +0200 (CEST) > Marton Balint wrote: > > > On Sun, 15 Apr 2018, Timo Teräs wrote: > > > > > Calculate DAR with assumed SAR 1:1 when SAR is undefined. Same > > > assumption is done in ffplay to create the pl

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-15 Thread Timo Teras
On Sun, 15 Apr 2018 16:42:01 +0200 (CEST) Marton Balint wrote: > On Sun, 15 Apr 2018, Timo Teräs wrote: > > > Calculate DAR with assumed SAR 1:1 when SAR is undefined. Same > > assumption is done in ffplay to create the play window. Usually > > DAR is more useful metadata than SAR when e.g. choo

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-15 Thread Carl Eugen Hoyos
2018-04-15 16:42 GMT+02:00, Marton Balint : > > > On Sun, 15 Apr 2018, Timo Teräs wrote: > >> Calculate DAR with assumed SAR 1:1 when SAR is undefined. Same >> assumption is done in ffplay to create the play window. Usually >> DAR is more useful metadata than SAR when e.g. choosing which >> media o

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-15 Thread Marton Balint
On Sun, 15 Apr 2018, Timo Teräs wrote: Calculate DAR with assumed SAR 1:1 when SAR is undefined. Same assumption is done in ffplay to create the play window. Usually DAR is more useful metadata than SAR when e.g. choosing which media of multiple versions to use to fit the display. Normally un

[FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-15 Thread Timo Teräs
Calculate DAR with assumed SAR 1:1 when SAR is undefined. Same assumption is done in ffplay to create the play window. Usually DAR is more useful metadata than SAR when e.g. choosing which media of multiple versions to use to fit the display. Normally undefined SAR means 1:1. E.g. in mov/mp4 files