Re: [FFmpeg-devel] [PATCH 1/2] Add experimental muxing support for FLAC in ISO BMFF (MP4).

2016-11-21 Thread Matthew Gregan
At 2016-11-21T15:56:23-0300, James Almer wrote: > Seeing the maintainer hasn't replied, i have pushed it. Seems to adhere to > the (draft) spec correctly, and is under an experimental strict check. Thanks for your assistance getting this reviewed and landed, much appreciated. > I tried creating s

Re: [FFmpeg-devel] [PATCH 1/2] Add experimental muxing support for FLAC in ISO BMFF (MP4).

2016-11-21 Thread James Almer
On 11/18/2016 12:25 AM, Matthew Gregan wrote: > At 2016-11-17T22:57:49-0300, James Almer wrote: >>> > > @@ -345,6 +346,7 @@ const AVCodecTag ff_codec_movaudio_tags[] = { >>> > > +{ AV_CODEC_ID_FLAC,MKTAG('f', 'L', 'a', 'C') }, /* >>> > > nonstandard */ >> > >> > This is enables mu

Re: [FFmpeg-devel] [PATCH 1/2] Add experimental muxing support for FLAC in ISO BMFF (MP4).

2016-11-17 Thread Matthew Gregan
At 2016-11-17T22:57:49-0300, James Almer wrote: > > @@ -345,6 +346,7 @@ const AVCodecTag ff_codec_movaudio_tags[] = { > > +{ AV_CODEC_ID_FLAC,MKTAG('f', 'L', 'a', 'C') }, /* > > nonstandard */ > > This is enables muxing into mov, which bypasses the experimental check below > since

Re: [FFmpeg-devel] [PATCH 1/2] Add experimental muxing support for FLAC in ISO BMFF (MP4).

2016-11-17 Thread James Almer
On 11/1/2016 8:21 PM, Matthew Gregan wrote: > At 2016-11-01T00:56:45-0300, James Almer wrote: >> > The muxer gets the extradata as created by the encoder only during init(). >> > Even if the encoder changes it in any way afterwards, it will never make >> > it to the muxer. That's why packet side da

Re: [FFmpeg-devel] [PATCH 1/2] Add experimental muxing support for FLAC in ISO BMFF (MP4).

2016-11-14 Thread James Almer
On 11/14/2016 10:38 PM, Matthew Gregan wrote: > Ping? It's been a couple of weeks since the last comment and patch update. > Can I help move this forward somehow? > > Firefox will be shipping experimental support for playback of FLAC in MP4 > based on the current spec in Firefox 51. CCing Matthie

Re: [FFmpeg-devel] [PATCH 1/2] Add experimental muxing support for FLAC in ISO BMFF (MP4).

2016-11-14 Thread Matthew Gregan
Ping? It's been a couple of weeks since the last comment and patch update. Can I help move this forward somehow? Firefox will be shipping experimental support for playback of FLAC in MP4 based on the current spec in Firefox 51. ___ ffmpeg-devel mailing l

Re: [FFmpeg-devel] [PATCH 1/2] Add experimental muxing support for FLAC in ISO BMFF (MP4).

2016-11-01 Thread Matthew Gregan
At 2016-11-01T00:56:45-0300, James Almer wrote: > The muxer gets the extradata as created by the encoder only during init(). > Even if the encoder changes it in any way afterwards, it will never make > it to the muxer. That's why packet side data is used for this. > > The reason the encoder used t

Re: [FFmpeg-devel] [PATCH 1/2] Add experimental muxing support for FLAC in ISO BMFF (MP4).

2016-10-31 Thread James Almer
On 10/31/2016 10:11 PM, Matthew Gregan wrote: > At 2016-10-31T11:04:16-0300, James Almer wrote: >>> +static int mov_write_dfla_tag(AVIOContext *pb, MOVTrack *track) >>> +{ >>> +const size_t FLAC_STREAMINFO_SIZE = 34; >>> +int64_t pos = avio_tell(pb); >>> +avio_wb32(pb, 0); >>> +ffio

Re: [FFmpeg-devel] [PATCH 1/2] Add experimental muxing support for FLAC in ISO BMFF (MP4).

2016-10-31 Thread Matthew Gregan
At 2016-10-31T11:04:16-0300, James Almer wrote: > > +static int mov_write_dfla_tag(AVIOContext *pb, MOVTrack *track) > > +{ > > +const size_t FLAC_STREAMINFO_SIZE = 34; > > +int64_t pos = avio_tell(pb); > > +avio_wb32(pb, 0); > > +ffio_wfourcc(pb, "dfLa"); > > +avio_w8(pb, 0); /

Re: [FFmpeg-devel] [PATCH 1/2] Add experimental muxing support for FLAC in ISO BMFF (MP4).

2016-10-31 Thread James Almer
On 10/31/2016 3:27 AM, Matthew Gregan wrote: > Based on the draft spec at > https://git.xiph.org/?p=flac.git;a=blob;f=doc/isoflac.txt > > '-strict -2' is required to create files in this format. > > Signed-off-by: Matthew Gregan > --- > libavformat/isom.c | 2 ++ > libavformat/movenc.c | 43

[FFmpeg-devel] [PATCH 1/2] Add experimental muxing support for FLAC in ISO BMFF (MP4).

2016-10-30 Thread Matthew Gregan
Based on the draft spec at https://git.xiph.org/?p=flac.git;a=blob;f=doc/isoflac.txt '-strict -2' is required to create files in this format. Signed-off-by: Matthew Gregan --- libavformat/isom.c | 2 ++ libavformat/movenc.c | 43 +-- 2 files changed,