Re: [FFmpeg-devel] [PATCH 1/2] avcodec/alacdec: split off decorrelate_stereo and append_extra_bits as alacdsp

2015-10-04 Thread Michael Niedermayer
On Sun, Oct 04, 2015 at 11:51:58PM +, Timothy Gu wrote: > On Sun, Oct 4, 2015 at 2:21 PM Michael Niedermayer wrote: > > > there is a spec ? > > > > Don't think so for the codec itself. > > > > i only know of soe reference source code and i looked yesterday > > and it

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/alacdec: split off decorrelate_stereo and append_extra_bits as alacdsp

2015-10-04 Thread Michael Niedermayer
On Sun, Oct 04, 2015 at 12:44:56AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/Makefile | 2 +- > libavcodec/alac.c| 65 > +++- > libavcodec/alacdsp.c | 57

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/alacdec: split off decorrelate_stereo and append_extra_bits as alacdsp

2015-10-04 Thread Michael Niedermayer
On Sun, Oct 04, 2015 at 01:31:27AM -0300, James Almer wrote: > On 10/4/2015 12:44 AM, James Almer wrote: > > Signed-off-by: James Almer > > --- > > libavcodec/Makefile | 2 +- > > libavcodec/alac.c| 65 > > +++- > >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/alacdec: split off decorrelate_stereo and append_extra_bits as alacdsp

2015-10-04 Thread James Almer
On 10/4/2015 7:35 AM, Michael Niedermayer wrote: > On Sun, Oct 04, 2015 at 01:31:27AM -0300, James Almer wrote: >>> +if (decorr_left_weight) { >> >> So while i was writing a checkasm unit i started looking at the possible >> values for this, and found out that apparently it's either 0 or

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/alacdec: split off decorrelate_stereo and append_extra_bits as alacdsp

2015-10-04 Thread James Almer
On 10/4/2015 8:04 AM, Michael Niedermayer wrote: > On Sun, Oct 04, 2015 at 12:44:56AM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/Makefile | 2 +- >> libavcodec/alac.c| 65 >> +++- >>

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/alacdec: split off decorrelate_stereo and append_extra_bits as alacdsp

2015-10-04 Thread Timothy Gu
On Sun, Oct 4, 2015 at 2:21 PM Michael Niedermayer wrote: > there is a spec ? > Don't think so for the codec itself. > i only know of soe reference source code and i looked yesterday > and it usesed the full 8 bits unless i missed something >

[FFmpeg-devel] [PATCH 1/2] avcodec/alacdec: split off decorrelate_stereo and append_extra_bits as alacdsp

2015-10-03 Thread James Almer
Signed-off-by: James Almer --- libavcodec/Makefile | 2 +- libavcodec/alac.c| 65 +++- libavcodec/alacdsp.c | 57 + libavcodec/alacdsp.h | 35 4 files