Re: [FFmpeg-devel] [PATCH 1/2] avcodec/bsf: Don't set defaults for AVClass without options

2020-03-21 Thread James Almer
On 3/20/2020 5:17 AM, Anton Khirnov wrote: > Quoting Andreas Rheinhardt (2020-03-18 17:10:37) >> Anton Khirnov: >>> Quoting Andreas Rheinhardt (2020-03-17 22:31:46) This happened for AVBSFContext. Signed-off-by: Andreas Rheinhardt --- >>> Maybe ok. Not sure if it's better to

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/bsf: Don't set defaults for AVClass without options

2020-03-20 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-03-18 17:10:37) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2020-03-17 22:31:46) > >> This happened for AVBSFContext. > >> > >> Signed-off-by: Andreas Rheinhardt > >> --- > > Maybe ok. Not sure if it's better to drop it because it's unused or keep > > it in

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/bsf: Don't set defaults for AVClass without options

2020-03-18 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2020-03-17 22:31:46) >> This happened for AVBSFContext. >> >> Signed-off-by: Andreas Rheinhardt >> --- > Maybe ok. Not sure if it's better to drop it because it's unused or keep > it in case someone adds options later. > My opinion is that whoever

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/bsf: Don't set defaults for AVClass without options

2020-03-18 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-03-17 22:31:46) > This happened for AVBSFContext. > > Signed-off-by: Andreas Rheinhardt > --- Maybe ok. Not sure if it's better to drop it because it's unused or keep it in case someone adds options later. -- Anton Khirnov

[FFmpeg-devel] [PATCH 1/2] avcodec/bsf: Don't set defaults for AVClass without options

2020-03-17 Thread Andreas Rheinhardt
This happened for AVBSFContext. Signed-off-by: Andreas Rheinhardt --- libavcodec/bsf.c | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c index 9dbf6a636d..d0e0d46068 100644 --- a/libavcodec/bsf.c +++ b/libavcodec/bsf.c @@ -45,8 +45,6 @@ void