Re: [FFmpeg-devel] [PATCH 1/2] avcodec/sbrdsp_fixed.c: remove input value limit for sbr_sum_square_c()

2019-02-09 Thread Michael Niedermayer
On Wed, Feb 06, 2019 at 08:23:15PM +0100, Carl Eugen Hoyos wrote: > 2019-02-06 20:17 GMT+01:00, Michael Niedermayer : > > On Wed, Feb 06, 2019 at 01:57:37PM +0100, Carl Eugen Hoyos wrote: > >> 2019-02-03 18:21 GMT+01:00, Michael Niedermayer : > >> > Fixes: 1377/clusterfuzz-testcase-minimized-548704

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/sbrdsp_fixed.c: remove input value limit for sbr_sum_square_c()

2019-02-06 Thread Carl Eugen Hoyos
2019-02-06 20:17 GMT+01:00, Michael Niedermayer : > On Wed, Feb 06, 2019 at 01:57:37PM +0100, Carl Eugen Hoyos wrote: >> 2019-02-03 18:21 GMT+01:00, Michael Niedermayer : >> > Fixes: 1377/clusterfuzz-testcase-minimized-5487049807233024 >> > Fixes: assertion failure in sbr_sum_square_c() >> >> This

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/sbrdsp_fixed.c: remove input value limit for sbr_sum_square_c()

2019-02-06 Thread Michael Niedermayer
On Wed, Feb 06, 2019 at 01:57:37PM +0100, Carl Eugen Hoyos wrote: > 2019-02-03 18:21 GMT+01:00, Michael Niedermayer : > > Fixes: 1377/clusterfuzz-testcase-minimized-5487049807233024 > > Fixes: assertion failure in sbr_sum_square_c() > > This changes the output, no? in normal cases, no it should n

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/sbrdsp_fixed.c: remove input value limit for sbr_sum_square_c()

2019-02-06 Thread Carl Eugen Hoyos
2019-02-03 18:21 GMT+01:00, Michael Niedermayer : > Fixes: 1377/clusterfuzz-testcase-minimized-5487049807233024 > Fixes: assertion failure in sbr_sum_square_c() This changes the output, no? Why are the asm implementations not affected? Carl Eugen ___ ff

[FFmpeg-devel] [PATCH 1/2] avcodec/sbrdsp_fixed.c: remove input value limit for sbr_sum_square_c()

2019-02-03 Thread Michael Niedermayer
Fixes: 1377/clusterfuzz-testcase-minimized-5487049807233024 Fixes: assertion failure in sbr_sum_square_c() Signed-off-by: Michael Niedermayer --- libavcodec/sbrdsp_fixed.c | 34 +++--- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/libavcodec/sbrdsp_f