Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9: Check in decode_tiles() if there is data remaining

2018-08-11 Thread Ronald S. Bultje
Hi, On Sat, Aug 11, 2018 at 6:55 AM, Michael Niedermayer wrote: > But if you still want a flag, i can add one for vp9. > That would be great, thank you for your consideration. Ronald ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9: Check in decode_tiles() if there is data remaining

2018-08-11 Thread Michael Niedermayer
On Fri, Aug 10, 2018 at 10:41:21PM -0400, Ronald S. Bultje wrote: > Hi, > > On Fri, Aug 10, 2018 at 6:54 PM, Michael Niedermayer > wrote: > > > On Fri, Aug 10, 2018 at 02:16:56AM -0400, Ronald S. Bultje wrote: > > > My objection: > > > if a file has exactly symbols of 8 bits in arithdata, then a

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9: Check in decode_tiles() if there is data remaining

2018-08-10 Thread Ronald S. Bultje
Hi, On Fri, Aug 10, 2018 at 6:54 PM, Michael Niedermayer wrote: > On Fri, Aug 10, 2018 at 02:16:56AM -0400, Ronald S. Bultje wrote: > > My objection: > > if a file has exactly symbols of 8 bits in arithdata, then after all > this, > > the arithcoder will signal empty and EOF, even though no erro

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9: Check in decode_tiles() if there is data remaining

2018-08-10 Thread Michael Niedermayer
On Fri, Aug 10, 2018 at 02:16:56AM -0400, Ronald S. Bultje wrote: > Hi Michael, > > On Thu, Aug 9, 2018 at 8:49 PM, Michael Niedermayer > wrote: > > > On Wed, Aug 08, 2018 at 10:00:42PM -0300, James Almer wrote: > > > > Apply this patch with changes to allow that specific condition and lets > >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9: Check in decode_tiles() if there is data remaining

2018-08-09 Thread Ronald S. Bultje
Hi Michael, On Thu, Aug 9, 2018 at 8:49 PM, Michael Niedermayer wrote: > On Wed, Aug 08, 2018 at 10:00:42PM -0300, James Almer wrote: > > Apply this patch with changes to allow that specific condition and lets > > not waste more time on this. > > this is the only change the patch does. Without i

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9: Check in decode_tiles() if there is data remaining

2018-08-09 Thread Michael Niedermayer
On Wed, Aug 08, 2018 at 10:00:42PM -0300, James Almer wrote: > On 8/8/2018 9:30 PM, Michael Niedermayer wrote: > > On Tue, Aug 07, 2018 at 09:07:11PM -0400, Ronald S. Bultje wrote: > >> Hi, > >> > >> On Tue, Aug 7, 2018 at 7:15 PM, Michael Niedermayer > >> > >> wrote: > >> > >>> On Mon, Aug 06, 2

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9: Check in decode_tiles() if there is data remaining

2018-08-08 Thread James Almer
On 8/8/2018 9:30 PM, Michael Niedermayer wrote: > On Tue, Aug 07, 2018 at 09:07:11PM -0400, Ronald S. Bultje wrote: >> Hi, >> >> On Tue, Aug 7, 2018 at 7:15 PM, Michael Niedermayer >> wrote: >> >>> On Mon, Aug 06, 2018 at 09:50:57PM -0400, Ronald S. Bultje wrote: Hi, On Mon, Aug 6,

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9: Check in decode_tiles() if there is data remaining

2018-08-08 Thread Michael Niedermayer
On Tue, Aug 07, 2018 at 09:07:11PM -0400, Ronald S. Bultje wrote: > Hi, > > On Tue, Aug 7, 2018 at 7:15 PM, Michael Niedermayer > wrote: > > > On Mon, Aug 06, 2018 at 09:50:57PM -0400, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Mon, Aug 6, 2018 at 3:00 PM, Michael Niedermayer > > > > > wr

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9: Check in decode_tiles() if there is data remaining

2018-08-07 Thread Ronald S. Bultje
Hi, On Tue, Aug 7, 2018 at 7:15 PM, Michael Niedermayer wrote: > On Mon, Aug 06, 2018 at 09:50:57PM -0400, Ronald S. Bultje wrote: > > Hi, > > > > On Mon, Aug 6, 2018 at 3:00 PM, Michael Niedermayer > > > wrote: > > > > > On Tue, Aug 07, 2018 at 01:05:51AM +0800, Ronald S. Bultje wrote: > > > >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9: Check in decode_tiles() if there is data remaining

2018-08-07 Thread Michael Niedermayer
On Mon, Aug 06, 2018 at 09:50:57PM -0400, Ronald S. Bultje wrote: > Hi, > > On Mon, Aug 6, 2018 at 3:00 PM, Michael Niedermayer > wrote: > > > On Tue, Aug 07, 2018 at 01:05:51AM +0800, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Sun, Aug 5, 2018, 9:17 AM Michael Niedermayer > > > > > wrote

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9: Check in decode_tiles() if there is data remaining

2018-08-06 Thread Ronald S. Bultje
Hi, On Mon, Aug 6, 2018 at 3:00 PM, Michael Niedermayer wrote: > On Tue, Aug 07, 2018 at 01:05:51AM +0800, Ronald S. Bultje wrote: > > Hi, > > > > On Sun, Aug 5, 2018, 9:17 AM Michael Niedermayer > > > wrote: > > > > > Fixes: Timeout > > > Fixes: > > > 9330/clusterfuzz-testcase-minimized-ffmpeg

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9: Check in decode_tiles() if there is data remaining

2018-08-06 Thread Michael Niedermayer
On Tue, Aug 07, 2018 at 01:05:51AM +0800, Ronald S. Bultje wrote: > Hi, > > On Sun, Aug 5, 2018, 9:17 AM Michael Niedermayer > wrote: > > > Fixes: Timeout > > Fixes: > > 9330/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP9_fuzzer-5707345857347584 > > > > Found-by: continuous fuzzing proces

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9: Check in decode_tiles() if there is data remaining

2018-08-06 Thread Ronald S. Bultje
Hi, On Sun, Aug 5, 2018, 9:17 AM Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 9330/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP9_fuzzer-5707345857347584 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by > <

[FFmpeg-devel] [PATCH 1/2] avcodec/vp9: Check in decode_tiles() if there is data remaining

2018-08-04 Thread Michael Niedermayer
Fixes: Timeout Fixes: 9330/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP9_fuzzer-5707345857347584 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vp9.c | 3 +++ 1 file changed, 3 insert