Re: [FFmpeg-devel] [PATCH 1/2] avcodec/wmv2dec: Check end of bitstream in parse_mb_skip() and ff_wmv2_decode_mb()

2017-09-19 Thread Michael Niedermayer
Hi Ronald On Mon, Sep 18, 2017 at 09:11:39AM -0400, Ronald S. Bultje wrote: > Hi Michael, > > On Sun, Sep 17, 2017 at 8:15 PM, Michael Niedermayer > wrote: > > > Iam happy to follow what the community prefers. > > > > Some don't like it, some don't care. I think everyone would be happy (and I

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/wmv2dec: Check end of bitstream in parse_mb_skip() and ff_wmv2_decode_mb()

2017-09-18 Thread Paul B Mahol
On 9/18/17, Carl Eugen Hoyos wrote: > 2017-09-18 15:11 GMT+02:00 Ronald S. Bultje : >> Hi Michael, >> >> On Sun, Sep 17, 2017 at 8:15 PM, Michael Niedermayer >> >> wrote: >> >>> Iam happy to follow what the community prefers. >>> >> >> Some don't like it, some don't care. I think everyone would be

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/wmv2dec: Check end of bitstream in parse_mb_skip() and ff_wmv2_decode_mb()

2017-09-18 Thread Carl Eugen Hoyos
2017-09-18 15:11 GMT+02:00 Ronald S. Bultje : > Hi Michael, > > On Sun, Sep 17, 2017 at 8:15 PM, Michael Niedermayer > wrote: > >> Iam happy to follow what the community prefers. >> > > Some don't like it, some don't care. I think everyone would be happy (and > thus the sum of happiness would incre

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/wmv2dec: Check end of bitstream in parse_mb_skip() and ff_wmv2_decode_mb()

2017-09-18 Thread Ronald S. Bultje
Hi Michael, On Sun, Sep 17, 2017 at 8:15 PM, Michael Niedermayer wrote: > Iam happy to follow what the community prefers. > Some don't like it, some don't care. I think everyone would be happy (and thus the sum of happiness would increase) if you changed this to ff_dlog() or something along tho

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/wmv2dec: Check end of bitstream in parse_mb_skip() and ff_wmv2_decode_mb()

2017-09-17 Thread Michael Niedermayer
Hi On Sun, Sep 17, 2017 at 04:16:13PM -0400, Ronald S. Bultje wrote: > Hi, > > On Sat, Sep 16, 2017 at 8:42 PM, Michael Niedermayer > wrote: > > > +if (get_bits_left(&s->gb) < 0) { > > +av_log(s->avctx, AV_LOG_ERROR, > > +"Insufficient bits left at %d %d\n", s->mb_x,

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/wmv2dec: Check end of bitstream in parse_mb_skip() and ff_wmv2_decode_mb()

2017-09-17 Thread Ronald S. Bultje
Hi, On Sat, Sep 16, 2017 at 8:42 PM, Michael Niedermayer wrote: > +if (get_bits_left(&s->gb) < 0) { > +av_log(s->avctx, AV_LOG_ERROR, > +"Insufficient bits left at %d %d\n", s->mb_x, s->mb_y); > +return AVERROR_INVALIDDATA; > +} We've talked about this b

[FFmpeg-devel] [PATCH 1/2] avcodec/wmv2dec: Check end of bitstream in parse_mb_skip() and ff_wmv2_decode_mb()

2017-09-16 Thread Michael Niedermayer
Fixes: Timeout Fixes: 3200/clusterfuzz-testcase-5750022136135680 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/wmv2dec.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletio