Re: [FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: mark the field flag if framerate > 30FPS

2020-07-29 Thread lance . lmwang
On Wed, Jul 29, 2020 at 10:16:33PM +0200, Marton Balint wrote: > > > > > > > > > > > if you tested with SDI with TC. > > > > > > > > > 00:00:00:24 > > > > > > > > > 00:00:00:24 > > > > > > > > > 00:00:00:00 > > > > > > > > > 00:00:00:00 > > I did tests, and depending on which timecode you

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: mark the field flag if framerate > 30FPS

2020-07-29 Thread Marton Balint
> > > > > if you tested with SDI with TC. > > > > > 00:00:00:24 > > > > > 00:00:00:24 > > > > > 00:00:00:00 > > > > > 00:00:00:00 I did tests, and depending on which timecode you select, and the timecode formats which are available in the SDI signal, this really can be the case, so you

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: mark the field flag if framerate > 30FPS

2020-07-20 Thread Marton Balint
On Mon, 20 Jul 2020, Marton Balint wrote: This feature looks like it belongs to av_timecode_get_smpte_from_framenum and not into decklink. I just sent a patch which implements this, because I confirmed that other code using av_timecode_get_smpte_from_framenum also seem to require the

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: mark the field flag if framerate > 30FPS

2020-07-20 Thread Marton Balint
On Mon, 20 Jul 2020, lance.lmw...@gmail.com wrote: On Sun, Jul 19, 2020 at 09:05:33AM +0200, Marton Balint wrote: On Sun, 19 Jul 2020, lance.lmw...@gmail.com wrote: > On Sat, Jul 18, 2020 at 08:38:16PM +0200, Marton Balint wrote: > > > > > > On Sat, 18 Jul 2020, lance.lmw...@gmail.com

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: mark the field flag if framerate > 30FPS

2020-07-20 Thread lance . lmwang
On Sun, Jul 19, 2020 at 09:05:33AM +0200, Marton Balint wrote: > > > On Sun, 19 Jul 2020, lance.lmw...@gmail.com wrote: > > > On Sat, Jul 18, 2020 at 08:38:16PM +0200, Marton Balint wrote: > > > > > > > > > On Sat, 18 Jul 2020, lance.lmw...@gmail.com wrote: > > > > > > > On Sat, Jul 18, 2020

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: mark the field flag if framerate > 30FPS

2020-07-19 Thread Marton Balint
On Sun, 19 Jul 2020, lance.lmw...@gmail.com wrote: On Sat, Jul 18, 2020 at 08:38:16PM +0200, Marton Balint wrote: On Sat, 18 Jul 2020, lance.lmw...@gmail.com wrote: > On Sat, Jul 18, 2020 at 09:44:03AM +0200, Marton Balint wrote: > > > > > > On Sat, 18 Jul 2020, lance.lmw...@gmail.com

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: mark the field flag if framerate > 30FPS

2020-07-18 Thread lance . lmwang
On Sat, Jul 18, 2020 at 08:38:16PM +0200, Marton Balint wrote: > > > On Sat, 18 Jul 2020, lance.lmw...@gmail.com wrote: > > > On Sat, Jul 18, 2020 at 09:44:03AM +0200, Marton Balint wrote: > > > > > > > > > On Sat, 18 Jul 2020, lance.lmw...@gmail.com wrote: > > > > > > > On Fri, Jul 17, 2020

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: mark the field flag if framerate > 30FPS

2020-07-18 Thread Marton Balint
On Sat, 18 Jul 2020, lance.lmw...@gmail.com wrote: On Sat, Jul 18, 2020 at 09:44:03AM +0200, Marton Balint wrote: On Sat, 18 Jul 2020, lance.lmw...@gmail.com wrote: > On Fri, Jul 17, 2020 at 07:13:28PM +0200, Marton Balint wrote: > > > > > > On Fri, 17 Jul 2020, lance.lmw...@gmail.com

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: mark the field flag if framerate > 30FPS

2020-07-18 Thread lance . lmwang
On Sat, Jul 18, 2020 at 09:44:03AM +0200, Marton Balint wrote: > > > On Sat, 18 Jul 2020, lance.lmw...@gmail.com wrote: > > > On Fri, Jul 17, 2020 at 07:13:28PM +0200, Marton Balint wrote: > > > > > > > > > On Fri, 17 Jul 2020, lance.lmw...@gmail.com wrote: > > > > > > > From: Limin Wang >

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: mark the field flag if framerate > 30FPS

2020-07-18 Thread Marton Balint
On Sat, 18 Jul 2020, lance.lmw...@gmail.com wrote: On Fri, Jul 17, 2020 at 07:13:28PM +0200, Marton Balint wrote: On Fri, 17 Jul 2020, lance.lmw...@gmail.com wrote: > From: Limin Wang > > In SMPTE ST 12-1: 2014 Sec 12.2, we need to mark the frame flag if the frame rate > 30FPS to >

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: mark the field flag if framerate > 30FPS

2020-07-17 Thread lance . lmwang
On Fri, Jul 17, 2020 at 07:13:28PM +0200, Marton Balint wrote: > > > On Fri, 17 Jul 2020, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > In SMPTE ST 12-1: 2014 Sec 12.2, we need to mark the frame flag if the > > frame rate > 30FPS to > > avoid interoperability issues. It will

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: mark the field flag if framerate > 30FPS

2020-07-17 Thread Marton Balint
On Fri, 17 Jul 2020, lance.lmw...@gmail.com wrote: From: Limin Wang In SMPTE ST 12-1: 2014 Sec 12.2, we need to mark the frame flag if the frame rate > 30FPS to avoid interoperability issues. It will be used by the encoder to identify even or odd frames and correctly calculate the frame

[FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: mark the field flag if framerate > 30FPS

2020-07-17 Thread lance . lmwang
From: Limin Wang In SMPTE ST 12-1: 2014 Sec 12.2, we need to mark the frame flag if the frame rate > 30FPS to avoid interoperability issues. It will be used by the encoder to identify even or odd frames and correctly calculate the frame number of the SEI TC. --- libavdevice/decklink_common.h