[FFmpeg-devel] [PATCH 1/2] avfilter/af_stereowiden: Check length

2023-12-23 Thread Michael Niedermayer
Fixes: out of array access Fixes: tickets/10746/poc13ffmpeg Found-by: Zeng Yunxiang Signed-off-by: Michael Niedermayer --- libavfilter/af_stereowiden.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/af_stereowiden.c b/libavfilter/af_stereowiden.c index af4b23e8a57..f7a6a91ae40

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/af_stereowiden: Check length

2023-12-24 Thread Paul B Mahol
This is highly suboptimal, use rounding-up. See librempeg code. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/af_stereowiden: Check length

2023-12-29 Thread Michael Niedermayer
On Sun, Dec 24, 2023 at 11:40:31AM +0100, Paul B Mahol wrote: > This is highly suboptimal, use rounding-up. changing the rounding does not fix the issue, a float can still evaluate to 0 so 0 needs to be checked thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB