[FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-02 Thread Marton Balint
It should be OK to use av_get_random_seed() to generate the key instead of using openSSL/Gcrypt functions. This removes the hard dependancy of those libs for key generation functionality. Fixes ticket #10441. Signed-off-by: Marton Balint --- libavformat/hlsenc.c | 18 -- 1 file

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-02 Thread Steven Liu
Marton Balint 于2023年7月3日周一 03:30写道: > > It should be OK to use av_get_random_seed() to generate the key instead of > using openSSL/Gcrypt functions. This removes the hard dependancy of those libs > for key generation functionality. > > Fixes ticket #10441. > > Signed-off-by: Marton Balint > --- >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-03 Thread Marton Balint
On Mon, 3 Jul 2023, Steven Liu wrote: Marton Balint 于2023年7月3日周一 03:30写道: It should be OK to use av_get_random_seed() to generate the key instead of using openSSL/Gcrypt functions. This removes the hard dependancy of those libs for key generation functionality. Fixes ticket #10441. Signed

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-03 Thread James Almer
On 7/2/2023 4:30 PM, Marton Balint wrote: It should be OK to use av_get_random_seed() to generate the key instead of using openSSL/Gcrypt functions. This removes the hard dependancy of those libs for key generation functionality. Fixes ticket #10441. Signed-off-by: Marton Balint --- libavfor

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-03 Thread Anton Khirnov
Quoting James Almer (2023-07-03 21:33:04) > On 7/2/2023 4:30 PM, Marton Balint wrote: > > It should be OK to use av_get_random_seed() to generate the key instead of > > using openSSL/Gcrypt functions. This removes the hard dependancy of those > > libs > > for key generation functionality. > > > >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-03 Thread Marton Balint
On Mon, 3 Jul 2023, James Almer wrote: On 7/2/2023 4:30 PM, Marton Balint wrote: It should be OK to use av_get_random_seed() to generate the key instead of using openSSL/Gcrypt functions. This removes the hard dependancy of those libs for key generation functionality. Fixes ticket #104

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-03 Thread Marton Balint
On Mon, 3 Jul 2023, Anton Khirnov wrote: Quoting James Almer (2023-07-03 21:33:04) On 7/2/2023 4:30 PM, Marton Balint wrote: It should be OK to use av_get_random_seed() to generate the key instead of using openSSL/Gcrypt functions. This removes the hard dependancy of those libs for key gene

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-03 Thread Anton Khirnov
Quoting Marton Balint (2023-07-03 22:54:41) > On Mon, 3 Jul 2023, Anton Khirnov wrote: > My patch use av_get_random_seed() which uses what the underlying OS > provides, BCrypt for Windows, /dev/urandom for Linux, arc4random() for > BSD/Mac. IOW it's a jungle of various paths, some of which are n

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-03 Thread Marton Balint
On Mon, 3 Jul 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-07-03 22:54:41) On Mon, 3 Jul 2023, Anton Khirnov wrote: My patch use av_get_random_seed() which uses what the underlying OS provides, BCrypt for Windows, /dev/urandom for Linux, arc4random() for BSD/Mac. IOW it's a jungl

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-03 Thread Michael Niedermayer
On Mon, Jul 03, 2023 at 11:09:54PM +0200, Anton Khirnov wrote: > Quoting Marton Balint (2023-07-03 22:54:41) > > On Mon, 3 Jul 2023, Anton Khirnov wrote: > > My patch use av_get_random_seed() which uses what the underlying OS > > provides, BCrypt for Windows, /dev/urandom for Linux, arc4random() f

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-03 Thread Anton Khirnov
Quoting Michael Niedermayer (2023-07-04 01:50:57) > On Mon, Jul 03, 2023 at 11:09:54PM +0200, Anton Khirnov wrote: > > Quoting Marton Balint (2023-07-03 22:54:41) > > > On Mon, 3 Jul 2023, Anton Khirnov wrote: > > > My patch use av_get_random_seed() which uses what the underlying OS > > > provides

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-04 Thread Kieran Kunhya
On Tue, 4 Jul 2023 at 06:54, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-07-04 01:50:57) > > On Mon, Jul 03, 2023 at 11:09:54PM +0200, Anton Khirnov wrote: > > > Quoting Marton Balint (2023-07-03 22:54:41) > > > > On Mon, 3 Jul 2023, Anton Khirnov wrote: > > > > My patch use av_get_r

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-04 Thread James Almer
On 7/4/2023 2:54 AM, Anton Khirnov wrote: Quoting Michael Niedermayer (2023-07-04 01:50:57) On Mon, Jul 03, 2023 at 11:09:54PM +0200, Anton Khirnov wrote: Quoting Marton Balint (2023-07-03 22:54:41) On Mon, 3 Jul 2023, Anton Khirnov wrote: My patch use av_get_random_seed() which uses what the

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-04 Thread Anton Khirnov
Quoting James Almer (2023-07-04 16:37:03) > On 7/4/2023 2:54 AM, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2023-07-04 01:50:57) > >> On Mon, Jul 03, 2023 at 11:09:54PM +0200, Anton Khirnov wrote: > >>> Quoting Marton Balint (2023-07-03 22:54:41) > On Mon, 3 Jul 2023, Anton Khirnov

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-04 Thread James Almer
On 7/3/2023 6:52 PM, Marton Balint wrote: On Mon, 3 Jul 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-07-03 22:54:41) On Mon, 3 Jul 2023, Anton Khirnov wrote: My patch use av_get_random_seed() which uses what the underlying OS provides, BCrypt for Windows, /dev/urandom for Linux, ar

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-04 Thread Marton Balint
On Tue, 4 Jul 2023, James Almer wrote: On 7/3/2023 6:52 PM, Marton Balint wrote: On Mon, 3 Jul 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-07-03 22:54:41) On Mon, 3 Jul 2023, Anton Khirnov wrote: My patch use av_get_random_seed() which uses what the underlying OS provides

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-04 Thread Michael Niedermayer
On Tue, Jul 04, 2023 at 07:54:06AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-07-04 01:50:57) > > On Mon, Jul 03, 2023 at 11:09:54PM +0200, Anton Khirnov wrote: > > > Quoting Marton Balint (2023-07-03 22:54:41) > > > > On Mon, 3 Jul 2023, Anton Khirnov wrote: > > > > My patch u

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-05 Thread Anton Khirnov
Quoting Michael Niedermayer (2023-07-05 01:50:12) > On Tue, Jul 04, 2023 at 07:54:06AM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2023-07-04 01:50:57) > > > On Mon, Jul 03, 2023 at 11:09:54PM +0200, Anton Khirnov wrote: > > > > Quoting Marton Balint (2023-07-03 22:54:41) > > > > >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-05 Thread Michael Niedermayer
On Wed, Jul 05, 2023 at 11:22:44AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-07-05 01:50:12) > > On Tue, Jul 04, 2023 at 07:54:06AM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2023-07-04 01:50:57) > > > > On Mon, Jul 03, 2023 at 11:09:54PM +0200, Anton Khirn

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-06 Thread Anton Khirnov
Quoting Michael Niedermayer (2023-07-06 00:54:47) > On Wed, Jul 05, 2023 at 11:22:44AM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2023-07-05 01:50:12) > > > On Tue, Jul 04, 2023 at 07:54:06AM +0200, Anton Khirnov wrote: > > > > Quoting Michael Niedermayer (2023-07-04 01:50:57) > >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-06 Thread Kieran Kunhya
On Thu, 6 Jul 2023, 08:52 Anton Khirnov, wrote: > > We are not claiming that. We are claiming that the random numbers > generated are (to the best of our ability, and that of the underlying > libraries we rely on) cryptographically secure. This means suitable for > use in state of the art cryptog

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-06 Thread Michael Niedermayer
On Thu, Jul 06, 2023 at 09:52:12AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-07-06 00:54:47) > > On Wed, Jul 05, 2023 at 11:22:44AM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2023-07-05 01:50:12) > > > > On Tue, Jul 04, 2023 at 07:54:06AM +0200, Anton Khirn

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-07 Thread Anton Khirnov
Quoting Michael Niedermayer (2023-07-07 02:55:46) > > The litteral wording was > "that guarantees either cryptographically secure randomness or an error." > > that was what i refered to. > > the wording used now: > "to the best of our ability, and that of the underlying libraries we rely on) >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-07 Thread Michael Niedermayer
On Fri, Jul 07, 2023 at 10:05:50AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-07-07 02:55:46) > > > > The litteral wording was > > "that guarantees either cryptographically secure randomness or an error." > > > > that was what i refered to. > > > > the wording used now: > >