Re: [FFmpeg-devel] [PATCH 1/2] avformat/microdvd: Use \n instead of \0 to end file header

2019-12-27 Thread Michael Niedermayer
On Fri, Dec 27, 2019 at 10:44:53AM +0100, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is dangerous to be right in matters on which the established authorities are wrong. -- Voltaire signature.asc Description:

Re: [FFmpeg-devel] [PATCH 1/2] avformat/microdvd: Use \n instead of \0 to end file header

2019-12-27 Thread Paul B Mahol
lgtm On 12/27/19, Andreas Rheinhardt wrote: > Andreas Rheinhardt: >> Andreas Rheinhardt: >>> Up until now, the microdvd demuxer uses av_strdup() to allocate the >>> extradata from a string; its length is set to strlen() + 1, i.e. >>> including the \0 at the end. Upon remuxing, the muxer would

Re: [FFmpeg-devel] [PATCH 1/2] avformat/microdvd: Use \n instead of \0 to end file header

2019-12-26 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Andreas Rheinhardt: >> Up until now, the microdvd demuxer uses av_strdup() to allocate the >> extradata from a string; its length is set to strlen() + 1, i.e. >> including the \0 at the end. Upon remuxing, the muxer would simply copy >> the extradata at the beginning,

Re: [FFmpeg-devel] [PATCH 1/2] avformat/microdvd: Use \n instead of \0 to end file header

2019-12-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Up until now, the microdvd demuxer uses av_strdup() to allocate the > extradata from a string; its length is set to strlen() + 1, i.e. > including the \0 at the end. Upon remuxing, the muxer would simply copy > the extradata at the beginning, including the \0. > > This

[FFmpeg-devel] [PATCH 1/2] avformat/microdvd: Use \n instead of \0 to end file header

2019-12-12 Thread Andreas Rheinhardt
Up until now, the microdvd demuxer uses av_strdup() to allocate the extradata from a string; its length is set to strlen() + 1, i.e. including the \0 at the end. Upon remuxing, the muxer would simply copy the extradata at the beginning, including the \0. This commit changes this by not adding the