Re: [FFmpeg-devel] [PATCH 1/2] avformat/oggparsevorbis: Update context on double init

2020-04-07 Thread Carl Eugen Hoyos
Am Di., 7. Apr. 2020 um 15:38 Uhr schrieb Anton Khirnov : > I believe such non-constructive information-free comments should be > - disregarded > - treated as a breach of the code of conduct, once we have an > enforceable one (which is hopefully soon) This is not he first time that you send an

Re: [FFmpeg-devel] [PATCH 1/2] avformat/oggparsevorbis: Update context on double init

2020-04-07 Thread Michael Niedermayer
On Tue, Apr 07, 2020 at 10:55:39AM +0200, Paul B Mahol wrote: > On 4/6/20, Michael Niedermayer wrote: > > On Mon, Apr 06, 2020 at 12:00:21PM +0200, Anton Khirnov wrote: > >> Quoting Michael Niedermayer (2020-04-05 00:38:41) > >> > Fixes: memleak > >> > >> Memleak of what/where/why? This is highly

Re: [FFmpeg-devel] [PATCH 1/2] avformat/oggparsevorbis: Update context on double init

2020-04-07 Thread Paul B Mahol
On 4/7/20, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-04-06 15:15:17) >> On Mon, Apr 06, 2020 at 12:00:21PM +0200, Anton Khirnov wrote: >> > Quoting Michael Niedermayer (2020-04-05 00:38:41) >> > > Fixes: memleak >> > >> > Memleak of what/where/why? This is highly non-obvious. >> >>

Re: [FFmpeg-devel] [PATCH 1/2] avformat/oggparsevorbis: Update context on double init

2020-04-07 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-04-06 15:15:17) > On Mon, Apr 06, 2020 at 12:00:21PM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2020-04-05 00:38:41) > > > Fixes: memleak > > > > Memleak of what/where/why? This is highly non-obvious. > > yes, i tend to be terse on "security" fi

Re: [FFmpeg-devel] [PATCH 1/2] avformat/oggparsevorbis: Update context on double init

2020-04-07 Thread Nicolas George
Paul B Mahol (12020-04-07): > I rejected patch, because Lynee reported over IRC, which you > thankfully completely ignored, bug that stops playing files. Next time, save everybody some time and say it directly there. Politeness is not for everybody else but you. -- Nicolas George signature.a

Re: [FFmpeg-devel] [PATCH 1/2] avformat/oggparsevorbis: Update context on double init

2020-04-07 Thread Paul B Mahol
On 4/6/20, Michael Niedermayer wrote: > On Mon, Apr 06, 2020 at 12:00:21PM +0200, Anton Khirnov wrote: >> Quoting Michael Niedermayer (2020-04-05 00:38:41) >> > Fixes: memleak >> >> Memleak of what/where/why? This is highly non-obvious. > > yes, i tend to be terse on "security" fixes so as not to

Re: [FFmpeg-devel] [PATCH 1/2] avformat/oggparsevorbis: Update context on double init

2020-04-06 Thread Michael Niedermayer
On Mon, Apr 06, 2020 at 12:00:21PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-04-05 00:38:41) > > Fixes: memleak > > Memleak of what/where/why? This is highly non-obvious. yes, i tend to be terse on "security" fixes so as not to provide a "how to exploit" what leaks is the

Re: [FFmpeg-devel] [PATCH 1/2] avformat/oggparsevorbis: Update context on double init

2020-04-06 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-04-05 00:38:41) > Fixes: memleak Memleak of what/where/why? This is highly non-obvious. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubs

[FFmpeg-devel] [PATCH 1/2] avformat/oggparsevorbis: Update context on double init

2020-04-04 Thread Michael Niedermayer
Fixes: memleak Fixes: 19949/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5743636058210304 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/oggparsevorbis.c | 1 + 1 file changed, 1 ins