Re: [FFmpeg-devel] [PATCH 1/2] avutil/buffer: add av_buffer_pool_buffer_get_opaque

2019-12-15 Thread James Almer
On 12/15/2019 11:24 AM, Nicolas George wrote: > James Almer (12019-12-14): >> I'm not sure if this is a good idea. It takes any AVBufferRef as input, >> so it will crash on pretty much every one not created by an AVBufferPool >> (unless it checks that buf is not NULL before dereferencing it), or >>

Re: [FFmpeg-devel] [PATCH 1/2] avutil/buffer: add av_buffer_pool_buffer_get_opaque

2019-12-15 Thread Nicolas George
James Almer (12019-12-14): > I'm not sure if this is a good idea. It takes any AVBufferRef as input, > so it will crash on pretty much every one not created by an AVBufferPool > (unless it checks that buf is not NULL before dereferencing it), or > return something unrelated otherwise. This is true

Re: [FFmpeg-devel] [PATCH 1/2] avutil/buffer: add av_buffer_pool_buffer_get_opaque

2019-12-14 Thread Marton Balint
On Sat, 14 Dec 2019, James Almer wrote: On 12/14/2019 7:50 PM, Marton Balint wrote: On Sat, 14 Dec 2019, James Almer wrote: On 12/7/2019 6:57 PM, Marton Balint wrote: In order to access the original opaque parameter of a buffer in the buffer pool. (The buffer pool implementation override

Re: [FFmpeg-devel] [PATCH 1/2] avutil/buffer: add av_buffer_pool_buffer_get_opaque

2019-12-14 Thread James Almer
On 12/14/2019 7:50 PM, Marton Balint wrote: > > > On Sat, 14 Dec 2019, James Almer wrote: > >> On 12/7/2019 6:57 PM, Marton Balint wrote: >>> In order to access the original opaque parameter of a buffer in the >>> buffer >>> pool. (The buffer pool implementation overrides the normal opaque >>> p

Re: [FFmpeg-devel] [PATCH 1/2] avutil/buffer: add av_buffer_pool_buffer_get_opaque

2019-12-14 Thread Marton Balint
On Sat, 14 Dec 2019, James Almer wrote: On 12/7/2019 6:57 PM, Marton Balint wrote: In order to access the original opaque parameter of a buffer in the buffer pool. (The buffer pool implementation overrides the normal opaque parameter but also saves it so it is accessible). Signed-off-by: Mar

Re: [FFmpeg-devel] [PATCH 1/2] avutil/buffer: add av_buffer_pool_buffer_get_opaque

2019-12-14 Thread James Almer
On 12/7/2019 6:57 PM, Marton Balint wrote: > In order to access the original opaque parameter of a buffer in the buffer > pool. (The buffer pool implementation overrides the normal opaque parameter > but > also saves it so it is accessible). > > Signed-off-by: Marton Balint > --- > doc/APIchang

Re: [FFmpeg-devel] [PATCH 1/2] avutil/buffer: add av_buffer_pool_buffer_get_opaque

2019-12-14 Thread Marton Balint
On Sat, 7 Dec 2019, Marton Balint wrote: In order to access the original opaque parameter of a buffer in the buffer pool. (The buffer pool implementation overrides the normal opaque parameter but also saves it so it is accessible). Ping. Will apply soon. Thanks, Marton Signed-off-by: Mar

[FFmpeg-devel] [PATCH 1/2] avutil/buffer: add av_buffer_pool_buffer_get_opaque

2019-12-07 Thread Marton Balint
In order to access the original opaque parameter of a buffer in the buffer pool. (The buffer pool implementation overrides the normal opaque parameter but also saves it so it is accessible). Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavutil/buffer.c | 6 ++ libavutil