Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: add av_rint64_clip

2015-11-13 Thread Ganesh Ajjanagadde
On Fri, Nov 13, 2015 at 5:33 PM, Michael Niedermayer wrote: > On Fri, Nov 13, 2015 at 07:38:31AM -0500, Ganesh Ajjanagadde wrote: >> On Fri, Nov 13, 2015 at 6:40 AM, Michael Niedermayer >> wrote: >> > On Thu, Nov 12, 2015 at 09:46:04PM -0500, Ganesh Ajjanagadde wrote: >> >> The rationale for this

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: add av_rint64_clip

2015-11-13 Thread Michael Niedermayer
On Fri, Nov 13, 2015 at 07:38:31AM -0500, Ganesh Ajjanagadde wrote: > On Fri, Nov 13, 2015 at 6:40 AM, Michael Niedermayer > wrote: > > On Thu, Nov 12, 2015 at 09:46:04PM -0500, Ganesh Ajjanagadde wrote: > >> The rationale for this function is reflected in the documentation for > >> it, and is cop

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: add av_rint64_clip

2015-11-13 Thread Ganesh Ajjanagadde
On Fri, Nov 13, 2015 at 9:10 AM, Ronald S. Bultje wrote: > Hi, > > On Fri, Nov 13, 2015 at 9:06 AM, Ganesh Ajjanagadde > wrote: >> >> On Fri, Nov 13, 2015 at 8:52 AM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Fri, Nov 13, 2015 at 8:08 AM, Ronald S. Bultje >> > wrote: >> >> >> >> Hi, >> >

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: add av_rint64_clip

2015-11-13 Thread Ronald S. Bultje
Hi, On Fri, Nov 13, 2015 at 9:06 AM, Ganesh Ajjanagadde wrote: > On Fri, Nov 13, 2015 at 8:52 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Fri, Nov 13, 2015 at 8:08 AM, Ronald S. Bultje > > wrote: > >> > >> Hi, > >> > >> On Thu, Nov 12, 2015 at 9:46 PM, Ganesh Ajjanagadde > >> wrote: > >>

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: add av_rint64_clip

2015-11-13 Thread Ganesh Ajjanagadde
On Fri, Nov 13, 2015 at 8:52 AM, Ronald S. Bultje wrote: > Hi, > > On Fri, Nov 13, 2015 at 8:08 AM, Ronald S. Bultje > wrote: >> >> Hi, >> >> On Thu, Nov 12, 2015 at 9:46 PM, Ganesh Ajjanagadde >> wrote: >>> >>> The rationale for this function is reflected in the documentation for >>> it, and is

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: add av_rint64_clip

2015-11-13 Thread Ronald S. Bultje
Hi, On Fri, Nov 13, 2015 at 8:08 AM, Ronald S. Bultje wrote: > Hi, > > On Thu, Nov 12, 2015 at 9:46 PM, Ganesh Ajjanagadde < > gajjanaga...@gmail.com> wrote: > >> The rationale for this function is reflected in the documentation for >> it, and is copied here: >> >> Clip a double value into the l

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: add av_rint64_clip

2015-11-13 Thread Ronald S. Bultje
Hi, On Thu, Nov 12, 2015 at 9:46 PM, Ganesh Ajjanagadde wrote: > The rationale for this function is reflected in the documentation for > it, and is copied here: > > Clip a double value into the long long amin-amax range. > This function is needed because conversion of floating point to integers

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: add av_rint64_clip

2015-11-13 Thread Ganesh Ajjanagadde
On Fri, Nov 13, 2015 at 7:05 AM, Pedro Arthur wrote: > >> +static av_always_inline av_const int64_t av_rint64_clip_c(double a, >> int64_t amin, int64_t amax) >> +{ >> +#if defined(HAVE_AV_CONFIG_H) && defined(ASSERT_LEVEL) && ASSERT_LEVEL >= >> 2 >> +if (amin > amax) abort(); >> +#endif >> +

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: add av_rint64_clip

2015-11-13 Thread Ganesh Ajjanagadde
On Fri, Nov 13, 2015 at 6:40 AM, Michael Niedermayer wrote: > On Thu, Nov 12, 2015 at 09:46:04PM -0500, Ganesh Ajjanagadde wrote: >> The rationale for this function is reflected in the documentation for >> it, and is copied here: >> >> Clip a double value into the long long amin-amax range. >> Thi

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: add av_rint64_clip

2015-11-13 Thread Ganesh Ajjanagadde
On Fri, Nov 13, 2015 at 7:29 AM, Ronald S. Bultje wrote: > Hi, > > On Thu, Nov 12, 2015 at 9:46 PM, Ganesh Ajjanagadde > wrote: >> >> The rationale for this function is reflected in the documentation for >> it, and is copied here: >> >> Clip a double value into the long long amin-amax range. >> T

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: add av_rint64_clip

2015-11-13 Thread Ronald S. Bultje
Hi, On Thu, Nov 12, 2015 at 9:46 PM, Ganesh Ajjanagadde wrote: > The rationale for this function is reflected in the documentation for > it, and is copied here: > > Clip a double value into the long long amin-amax range. > This function is needed because conversion of floating point to integers

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: add av_rint64_clip

2015-11-13 Thread Pedro Arthur
> +static av_always_inline av_const int64_t av_rint64_clip_c(double a, > int64_t amin, int64_t amax) > +{ > +#if defined(HAVE_AV_CONFIG_H) && defined(ASSERT_LEVEL) && ASSERT_LEVEL >= > 2 > +if (amin > amax) abort(); > +#endif > +// INT64_MAX+1,INT64_MIN are exactly representable as IEEE dou

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: add av_rint64_clip

2015-11-13 Thread Michael Niedermayer
On Thu, Nov 12, 2015 at 09:46:04PM -0500, Ganesh Ajjanagadde wrote: > The rationale for this function is reflected in the documentation for > it, and is copied here: > > Clip a double value into the long long amin-amax range. > This function is needed because conversion of floating point to intege

[FFmpeg-devel] [PATCH 1/2] avutil/common: add av_rint64_clip

2015-11-12 Thread Ganesh Ajjanagadde
The rationale for this function is reflected in the documentation for it, and is copied here: Clip a double value into the long long amin-amax range. This function is needed because conversion of floating point to integers when it does not fit in the integer's representation does not necessarily s