Re: [FFmpeg-devel] [PATCH 1/2] avutil/log: Add av_log_once() for printing a message just once per instance

Quoting Michael Niedermayer (2020-01-29 12:25:42) > On Tue, Jan 28, 2020 at 07:38:45PM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2020-01-24 13:04:08) > > > On Tue, Jan 21, 2020 at 07:44:46PM +0100, Anton Khirnov wrote: > > > > Quoting Michael Niedermayer (2020-01-21 15:43:48) > >

Re: [FFmpeg-devel] [PATCH 1/2] avutil/log: Add av_log_once() for printing a message just once per instance

On Tue, Jan 28, 2020 at 07:38:45PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-01-24 13:04:08) > > On Tue, Jan 21, 2020 at 07:44:46PM +0100, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2020-01-21 15:43:48) > > > > On Tue, Jan 21, 2020 at 12:24:50PM +0100, Anton Khirn

Re: [FFmpeg-devel] [PATCH 1/2] avutil/log: Add av_log_once() for printing a message just once per instance

Quoting Michael Niedermayer (2020-01-24 13:04:08) > On Tue, Jan 21, 2020 at 07:44:46PM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2020-01-21 15:43:48) > > > On Tue, Jan 21, 2020 at 12:24:50PM +0100, Anton Khirnov wrote: > > > > Quoting Michael Niedermayer (2020-01-16 17:51:28) > >

Re: [FFmpeg-devel] [PATCH 1/2] avutil/log: Add av_log_once() for printing a message just once per instance

On Tue, Jan 21, 2020 at 07:44:46PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-01-21 15:43:48) > > On Tue, Jan 21, 2020 at 12:24:50PM +0100, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2020-01-16 17:51:28) > > > > Compared to ad-hoc if(printed) ... code this allows t

Re: [FFmpeg-devel] [PATCH 1/2] avutil/log: Add av_log_once() for printing a message just once per instance

Quoting Michael Niedermayer (2020-01-21 15:43:48) > On Tue, Jan 21, 2020 at 12:24:50PM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2020-01-16 17:51:28) > > > Compared to ad-hoc if(printed) ... code this allows the user to disable > > > it with a flag and see all repeated messages,

Re: [FFmpeg-devel] [PATCH 1/2] avutil/log: Add av_log_once() for printing a message just once per instance

On Tue, Jan 21, 2020 at 12:24:50PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-01-16 17:51:28) > > Compared to ad-hoc if(printed) ... code this allows the user to disable > > it with a flag and see all repeated messages, it is also simpler > > That flag is global state - it sho

Re: [FFmpeg-devel] [PATCH 1/2] avutil/log: Add av_log_once() for printing a message just once per instance

Quoting Michael Niedermayer (2020-01-16 17:51:28) > Compared to ad-hoc if(printed) ... code this allows the user to disable > it with a flag and see all repeated messages, it is also simpler That flag is global state - it should be deprecated and removed, not embedded further into the API. > > T

[FFmpeg-devel] [PATCH 1/2] avutil/log: Add av_log_once() for printing a message just once per instance

Compared to ad-hoc if(printed) ... code this allows the user to disable it with a flag and see all repeated messages, it is also simpler TODO: APIChanges & version bump Signed-off-by: Michael Niedermayer --- libavutil/log.c | 15 +++ libavutil/log.h | 19 +++ 2 files