Re: [FFmpeg-devel] [PATCH 1/2] lavc/aac_ac3_parser: fix the potential overflow

On 2020-07-31 09:45 +0800, myp...@gmail.com wrote: > On Fri, Jul 31, 2020 at 3:47 AM Alexander Strasser wrote: > > > > On 2020-07-30 21:18 +0800, myp...@gmail.com wrote: > > > > > > After repeated thinking， I can accept this solution, thx > > > > Just to avoid confusion. You accept this > > > > >

Re: [FFmpeg-devel] [PATCH 1/2] lavc/aac_ac3_parser: fix the potential overflow

On Fri, Jul 31, 2020 at 3:47 AM Alexander Strasser wrote: > > On 2020-07-30 21:18 +0800, myp...@gmail.com wrote: > > > > After repeated thinking， I can accept this solution, thx > > Just to avoid confusion. You accept this > > > > > > avctx->bit_rate += (s->bit_rate - avctx->bit_rate) /

Re: [FFmpeg-devel] [PATCH 1/2] lavc/aac_ac3_parser: fix the potential overflow

On 2020-07-30 21:18 +0800, myp...@gmail.com wrote: > > After repeated thinking， I can accept this solution, thx Just to avoid confusion. You accept this > > > > avctx->bit_rate += (s->bit_rate - avctx->bit_rate) / s->frame_number; or this > > If you are aiming for improving accuracy, I guess

Re: [FFmpeg-devel] [PATCH 1/2] lavc/aac_ac3_parser: fix the potential overflow

On Sat, Jul 25, 2020 at 3:21 AM Alexander Strasser wrote: > > On 2020-07-24 19:56 +0800, zhilizhao wrote: > > > > > > > On Jul 24, 2020, at 9:40 AM, myp...@gmail.com wrote: > > > > > > On Fri, Jul 24, 2020 at 4:43 AM Alexander Strasser > > > wrote: > > >> > > >> On

Re: [FFmpeg-devel] [PATCH 1/2] lavc/aac_ac3_parser: fix the potential overflow

On 2020-07-24 19:56 +0800, zhilizhao wrote: > > > > On Jul 24, 2020, at 9:40 AM, myp...@gmail.com wrote: > > > > On Fri, Jul 24, 2020 at 4:43 AM Alexander Strasser > > wrote: > >> > >> On 2020-07-01 21:05 +0200, Alexander Strasser wrote: > >>> On 2020-07-01 16:23 +0200,

Re: [FFmpeg-devel] [PATCH 1/2] lavc/aac_ac3_parser: fix the potential overflow

> On Jul 24, 2020, at 9:40 AM, myp...@gmail.com wrote: > > On Fri, Jul 24, 2020 at 4:43 AM Alexander Strasser > wrote: >> >> On 2020-07-01 21:05 +0200, Alexander Strasser wrote: >>> On 2020-07-01 16:23 +0200, Anton Khirnov wrote: Quoting Jun Zhao (2020-06-29

Re: [FFmpeg-devel] [PATCH 1/2] lavc/aac_ac3_parser: fix the potential overflow

On Fri, Jul 24, 2020 at 4:43 AM Alexander Strasser wrote: > > On 2020-07-01 21:05 +0200, Alexander Strasser wrote: > > On 2020-07-01 16:23 +0200, Anton Khirnov wrote: > > > Quoting Jun Zhao (2020-06-29 15:23:10) > > > > From: Jun Zhao > > > > > > > > Fix the potential overflow. > > > > > > > >

Re: [FFmpeg-devel] [PATCH 1/2] lavc/aac_ac3_parser: fix the potential overflow

On 2020-07-01 21:05 +0200, Alexander Strasser wrote: > On 2020-07-01 16:23 +0200, Anton Khirnov wrote: > > Quoting Jun Zhao (2020-06-29 15:23:10) > > > From: Jun Zhao > > > > > > Fix the potential overflow. > > > > > > Suggested-by: Alexander Strasser > > > Signed-off-by: Jun Zhao > > > --- > >

Re: [FFmpeg-devel] [PATCH 1/2] lavc/aac_ac3_parser: fix the potential overflow

Hi Anton, hi Jun! On 2020-07-01 16:23 +0200, Anton Khirnov wrote: > Quoting Jun Zhao (2020-06-29 15:23:10) > > From: Jun Zhao > > > > Fix the potential overflow. > > > > Suggested-by: Alexander Strasser > > Signed-off-by: Jun Zhao > > --- > > libavcodec/aac_ac3_parser.c | 9 +

Re: [FFmpeg-devel] [PATCH 1/2] lavc/aac_ac3_parser: fix the potential overflow

Quoting Jun Zhao (2020-06-29 15:23:10) > From: Jun Zhao > > Fix the potential overflow. > > Suggested-by: Alexander Strasser > Signed-off-by: Jun Zhao > --- > libavcodec/aac_ac3_parser.c | 9 + > libavcodec/aac_ac3_parser.h | 4 ++-- >

[FFmpeg-devel] [PATCH 1/2] lavc/aac_ac3_parser: fix the potential overflow

From: Jun Zhao Fix the potential overflow. Suggested-by: Alexander Strasser Signed-off-by: Jun Zhao --- libavcodec/aac_ac3_parser.c | 9 + libavcodec/aac_ac3_parser.h | 4 ++-- tests/ref/fate/adtstoasc_ticket3715 | 2 +- 3 files changed, 8 insertions(+), 7