The issue is that avci->skip_samples will be overridden by any side-data.
When operating on raw files (adts, for example), the decoder is free
to decide the amount of samples to skip. Usually, this is the algorithmic
delay of the decoder.
When operating on more complete containers, like ISOBMFF,
Current interaction between AV_FRAME_DATA_SKIP_SAMPLES and
AVCodecContext.skip_samples seems unncecessarily complicated to me and
you're just making it worse.
Is there any reason we can't drop AVCodecContext.skip_samples entirely
and signal it purely through side data? Then decoders could fully
co
Oct 19, 2023, 10:39 by an...@khirnov.net:
> Current interaction between AV_FRAME_DATA_SKIP_SAMPLES and
> AVCodecContext.skip_samples seems unncecessarily complicated to me and
> you're just making it worse.
>
> Is there any reason we can't drop AVCodecContext.skip_samples entirely
> and signal it
On 10/19/2023 5:39 AM, Anton Khirnov wrote:
Current interaction between AV_FRAME_DATA_SKIP_SAMPLES and
AVCodecContext.skip_samples seems unncecessarily complicated to me and
you're just making it worse.
Is there any reason we can't drop AVCodecContext.skip_samples entirely
and signal it purely t
Quoting Lynne (2023-10-19 14:49:46)
> Oct 19, 2023, 10:39 by an...@khirnov.net:
>
> > Current interaction between AV_FRAME_DATA_SKIP_SAMPLES and
> > AVCodecContext.skip_samples seems unncecessarily complicated to me and
> > you're just making it worse.
> >
> > Is there any reason we can't drop AVC