On Fri, 2020-12-04 at 10:21 -0300, James Almer wrote:
> On 12/4/2020 7:24 AM, Anton Khirnov wrote:
> > Quoting Haihao Xiang (2020-11-23 09:16:13)
> > > ff_qsv_print_iopattern, ff_qsv_print_error and ff_qsv_print_warning can be
> > > used outside of lavc. In addition, ff_qsv_map_error is used in
> >
On 12/4/2020 7:24 AM, Anton Khirnov wrote:
Quoting Haihao Xiang (2020-11-23 09:16:13)
ff_qsv_print_iopattern, ff_qsv_print_error and ff_qsv_print_warning can be
used outside of lavc. In addition, ff_qsv_map_error is used in
libavcodec/qsv.c only, so remove ff_ from ff_qsv_map_error and make it
s
On Fri, 2020-12-04 at 11:24 +0100, Anton Khirnov wrote:
> Quoting Haihao Xiang (2020-11-23 09:16:13)
> > ff_qsv_print_iopattern, ff_qsv_print_error and ff_qsv_print_warning can be
> > used outside of lavc. In addition, ff_qsv_map_error is used in
> > libavcodec/qsv.c only, so remove ff_ from ff_qsv
Anton Khirnov (12020-12-04):
> Those should either be inline in a private header, or exported as proper
> public API from libavutil.
What a waste of energy.
And you still haven't given a single practical benefit of keeping the
libraries separate that could not be achieved more efficiently
otherwi
Quoting Haihao Xiang (2020-11-23 09:16:13)
> ff_qsv_print_iopattern, ff_qsv_print_error and ff_qsv_print_warning can be
> used outside of lavc. In addition, ff_qsv_map_error is used in
> libavcodec/qsv.c only, so remove ff_ from ff_qsv_map_error and make it
> static.
>
> Signed-off-by: Haihao Xian
ff_qsv_print_iopattern, ff_qsv_print_error and ff_qsv_print_warning can be
used outside of lavc. In addition, ff_qsv_map_error is used in
libavcodec/qsv.c only, so remove ff_ from ff_qsv_map_error and make it
static.
Signed-off-by: Haihao Xiang
---
libavcodec/Makefile| 2 +-
libavco