Re: [FFmpeg-devel] [PATCH 1/2] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

On Wed, Jun 08, 2016 at 10:46:49AM -0700, Jon Toohill wrote: > Michael et al., is this good to merge as-is? I just tested and a round trip > with ffmpeg from wav -> mp3 -> wav retains the correct number of samples. There seems to be a inconsistency try the patch below with your patch, and write

Re: [FFmpeg-devel] [PATCH 1/2] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

Michael et al., is this good to merge as-is? I just tested and a round trip with ffmpeg from wav -> mp3 -> wav retains the correct number of samples. Jon Toohill | Google Play Music | jtooh...@google.com | (650) 215-0770 On Wed, Jun 1, 2016 at 5:58 PM, Jon Toohill

Re: [FFmpeg-devel] [PATCH 1/2] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

Based on my understanding of [1], these values in the Info tag specify only the encoder delay/padding, which matches the documentation for these fields. It looks like other formats are using the fields that way as well. I think the extra 528 + 1 samples are the decoder delay [2]. It looks like

Re: [FFmpeg-devel] [PATCH 1/2] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

On Wed, May 25, 2016 at 09:56:59AM -0700, Jon Toohill wrote: > --- > libavformat/mp3dec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c > index 3725d67..192f5ef 100644 > --- a/libavformat/mp3dec.c > +++ b/libavformat/mp3dec.c > @@ -234,6

Re: [FFmpeg-devel] [PATCH 1/2] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

On 5/26/2016 11:05 PM, Michael Niedermayer wrote: > On Wed, May 25, 2016 at 02:18:38PM -0400, Ronald S. Bultje wrote: >> Hi, >> >> On Wed, May 25, 2016 at 1:24 PM, James Almer wrote: >> >>> On 5/25/2016 1:56 PM, Jon Toohill wrote: --- libavformat/mp3dec.c | 2 ++

Re: [FFmpeg-devel] [PATCH 1/2] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

On Wed, May 25, 2016 at 02:18:38PM -0400, Ronald S. Bultje wrote: > Hi, > > On Wed, May 25, 2016 at 1:24 PM, James Almer wrote: > > > On 5/25/2016 1:56 PM, Jon Toohill wrote: > > > --- > > > libavformat/mp3dec.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff

Re: [FFmpeg-devel] [PATCH 1/2] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

Hi, On Wed, May 25, 2016 at 1:24 PM, James Almer wrote: > On 5/25/2016 1:56 PM, Jon Toohill wrote: > > --- > > libavformat/mp3dec.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c > > index 3725d67..192f5ef 100644

Re: [FFmpeg-devel] [PATCH 1/2] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

On 5/25/2016 1:56 PM, Jon Toohill wrote: > --- > libavformat/mp3dec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c > index 3725d67..192f5ef 100644 > --- a/libavformat/mp3dec.c > +++ b/libavformat/mp3dec.c > @@ -234,6 +234,8 @@ static void

[FFmpeg-devel] [PATCH 1/2] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

--- libavformat/mp3dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index 3725d67..192f5ef 100644 --- a/libavformat/mp3dec.c +++ b/libavformat/mp3dec.c @@ -234,6 +234,8 @@ static void mp3_parse_info_tag(AVFormatContext *s, AVStream *st,

[FFmpeg-devel] [PATCH 1/2] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

From: Jon Toohill --- libavformat/mp3dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index 3725d67..192f5ef 100644 --- a/libavformat/mp3dec.c +++ b/libavformat/mp3dec.c @@ -234,6 +234,8 @@ static void