Re: [FFmpeg-devel] [PATCH 1/2] lavu/dict: fix set function when reuse existing key pointer

2015-04-02 Thread Lukasz Marek
On 02.04.2015 01:09, Michael Niedermayer wrote: On Thu, Apr 02, 2015 at 12:37:34AM +0200, Lukasz Marek wrote: On 01.04.2015 04:33, Michael Niedermayer wrote: On Wed, Apr 01, 2015 at 03:25:23AM +0200, Lukasz Marek wrote: Fixes following scenario: av_dict_set(&d, "key", "old", 0); AVDictionaryE

Re: [FFmpeg-devel] [PATCH 1/2] lavu/dict: fix set function when reuse existing key pointer

2015-04-01 Thread Michael Niedermayer
On Thu, Apr 02, 2015 at 12:37:34AM +0200, Lukasz Marek wrote: > On 01.04.2015 04:33, Michael Niedermayer wrote: > >On Wed, Apr 01, 2015 at 03:25:23AM +0200, Lukasz Marek wrote: > >>Fixes following scenario: > >> > >>av_dict_set(&d, "key", "old", 0); > >>AVDictionaryEentry *e = av_dict_get(d, "key",

Re: [FFmpeg-devel] [PATCH 1/2] lavu/dict: fix set function when reuse existing key pointer

2015-04-01 Thread Lukasz Marek
On 01.04.2015 04:33, Michael Niedermayer wrote: On Wed, Apr 01, 2015 at 03:25:23AM +0200, Lukasz Marek wrote: Fixes following scenario: av_dict_set(&d, "key", "old", 0); AVDictionaryEentry *e = av_dict_get(d, "key", NULL, 0); av_dict_set(&d, e->key, "new", 0); Signed-off-by: Lukasz Marek ---

Re: [FFmpeg-devel] [PATCH 1/2] lavu/dict: fix set function when reuse existing key pointer

2015-03-31 Thread Michael Niedermayer
On Wed, Apr 01, 2015 at 03:25:23AM +0200, Lukasz Marek wrote: > Fixes following scenario: > > av_dict_set(&d, "key", "old", 0); > AVDictionaryEentry *e = av_dict_get(d, "key", NULL, 0); > av_dict_set(&d, e->key, "new", 0); > > Signed-off-by: Lukasz Marek > --- > libavutil/dict.c | 18 ++

[FFmpeg-devel] [PATCH 1/2] lavu/dict: fix set function when reuse existing key pointer

2015-03-31 Thread Lukasz Marek
Fixes following scenario: av_dict_set(&d, "key", "old", 0); AVDictionaryEentry *e = av_dict_get(d, "key", NULL, 0); av_dict_set(&d, e->key, "new", 0); Signed-off-by: Lukasz Marek --- libavutil/dict.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/libavut