Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

On Thu, Dec 1, 2016 at 3:01 PM, Nicolas George wrote: > Le primidi 11 frimaire, an CCXXV, Vittorio Giovara a écrit : >> Actually we already do, theora, vp8, vp9 and a few others have >> completely different values for most color properties, and we just >> check before

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

On Thu, Dec 1, 2016 at 2:22 PM, Nicolas George wrote: > Le primidi 11 frimaire, an CCXXV, Rostislav Pehlivanov a écrit : >> Why do you insist on having a hole in the first place? > > Apparently, the values of the enum are used encode and decode > standardized values in

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

Le primidi 11 frimaire, an CCXXV, Vittorio Giovara a écrit : > Actually we already do, theora, vp8, vp9 and a few others have > completely different values for most color properties, and we just > check before initializing the context or frame fields. Since iso/itu > codecs are the ones that more

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

Le primidi 11 frimaire, an CCXXV, Rostislav Pehlivanov a écrit : > Why do you insist on having a hole in the first place? Apparently, the values of the enum are used encode and decode standardized values in standardized formats like MPEG. I think this is a terrible design decision, and I would

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

On 1 December 2016 at 17:25, Vittorio Giovara wrote: > On Wed, Nov 30, 2016 at 5:48 PM, Ronald S. Bultje > wrote: > > Hi, > > > > On Wed, Nov 30, 2016 at 5:26 PM, Andreas Cadhalpun > > wrote: > >> > >> On

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

On Wed, Nov 30, 2016 at 5:48 PM, Ronald S. Bultje wrote: > Hi, > > On Wed, Nov 30, 2016 at 5:26 PM, Andreas Cadhalpun > wrote: >> >> On 30.11.2016 22:55, Ronald S. Bultje wrote: >> > On Wed, Nov 30, 2016 at 4:51 PM, Andreas Cadhalpun < >> >

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

Hi, On Wed, Nov 30, 2016 at 5:26 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 30.11.2016 22:55, Ronald S. Bultje wrote: > > On Wed, Nov 30, 2016 at 4:51 PM, Andreas Cadhalpun < > > andreas.cadhal...@googlemail.com> wrote: > > > >> On 30.11.2016 19:16, Vittorio Giovara

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

On 11/30/2016 7:26 PM, Andreas Cadhalpun wrote: > On 30.11.2016 22:55, Ronald S. Bultje wrote: >> On Wed, Nov 30, 2016 at 4:51 PM, Andreas Cadhalpun < >> andreas.cadhal...@googlemail.com> wrote: >> >>> On 30.11.2016 19:16, Vittorio Giovara wrote: >>> You can't just add a gap like that. >>> The

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

On 30.11.2016 22:55, Ronald S. Bultje wrote: > On Wed, Nov 30, 2016 at 4:51 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> On 30.11.2016 19:16, Vittorio Giovara wrote: >> You can't just add a gap like that. >> The current code assumes that the numbers are consecutive,

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

On 30.11.2016 19:16, Vittorio Giovara wrote: > Signed-off-by: Vittorio Giovara > --- > Please CC. > Vittorio > > libavutil/pixdesc.c | 1 + > libavutil/pixfmt.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c >

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

On 11/30/2016 5:16 PM, Nicolas George wrote: > Le decadi 10 frimaire, an CCXXV, Vittorio Giovara a écrit : >> I am sorry, I don't have any public link I can share. > > Ok. Thanks for James for his gratis-but-sell-your-soul link. > >>> But I am pretty sure this document does not specify the

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

Le decadi 10 frimaire, an CCXXV, Vittorio Giovara a écrit : > I am sorry, I don't have any public link I can share. Ok. Thanks for James for his gratis-but-sell-your-soul link. > > But I am pretty sure this document does not specify the values of enums > > in FFmpeg's API. If the rest of the

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

On 11/30/2016 4:51 PM, Nicolas George wrote: > Le decadi 10 frimaire, an CCXXV, Vittorio Giovara a écrit : >> This is the value specified in the 23001-8_2013 document. > > This looks paywalled. Please give links to public versions of specs in > that kind of case.

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

On Wed, Nov 30, 2016 at 2:51 PM, Nicolas George wrote: > Le decadi 10 frimaire, an CCXXV, Vittorio Giovara a écrit : >> This is the value specified in the 23001-8_2013 document. > > This looks paywalled. Please give links to public versions of specs in > that kind of case. I am

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

Le decadi 10 frimaire, an CCXXV, Vittorio Giovara a écrit : > This is the value specified in the 23001-8_2013 document. This looks paywalled. Please give links to public versions of specs in that kind of case. But I am pretty sure this document does not specify the values of enums in FFmpeg's

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

On Wed, Nov 30, 2016 at 1:21 PM, Nicolas George wrote: > Le decadi 10 frimaire, an CCXXV, Vittorio Giovara a écrit : >> Signed-off-by: Vittorio Giovara >> --- > >> Please CC. > > You can achieve the same result more reliably by setting the reply-to >

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

Le decadi 10 frimaire, an CCXXV, Vittorio Giovara a écrit : > Signed-off-by: Vittorio Giovara > --- > Please CC. You can achieve the same result more reliably by setting the reply-to header. > Vittorio > > libavutil/pixdesc.c | 1 + > libavutil/pixfmt.h | 1 + >

[FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

Signed-off-by: Vittorio Giovara --- Please CC. Vittorio libavutil/pixdesc.c | 1 + libavutil/pixfmt.h | 1 + 2 files changed, 2 insertions(+) diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c index 3b9c45d..04eab0b 100644 --- a/libavutil/pixdesc.c +++