Re: [FFmpeg-devel] [PATCH 1/2] webmdashenc: Require the 'adaptation_sets' option to be ste

2017-04-20 Thread Derek Buitenhuis
On 4/20/2017 4:58 PM, James Almer wrote: > EINVAL IMO, since it's an user option. AVERROR_INVALIDDATA was defined as AVERROR(EINVAL) for years, I guess I forgot it changed to something else... git blame puts it at 72af5d8a020e4dca1118b3ede67be983b33e27c5 in 2010... My memory was seriously

Re: [FFmpeg-devel] [PATCH 1/2] webmdashenc: Require the 'adaptation_sets' option to be ste

2017-04-20 Thread Michael Niedermayer
On Thu, Apr 20, 2017 at 12:58:54PM -0300, James Almer wrote: > On 4/20/2017 9:14 AM, Derek Buitenhuis wrote: > >This seems to be non-optional, and if the muxer is run without it, > >strlen() is run on NULL, causing a segfault. > > > >Signed-off-by: Derek Buitenhuis >

Re: [FFmpeg-devel] [PATCH 1/2] webmdashenc: Require the 'adaptation_sets' option to be ste

2017-04-20 Thread James Almer
On 4/20/2017 9:14 AM, Derek Buitenhuis wrote: This seems to be non-optional, and if the muxer is run without it, strlen() is run on NULL, causing a segfault. Signed-off-by: Derek Buitenhuis --- libavformat/webmdashenc.c | 4 1 file changed, 4 insertions(+)

Re: [FFmpeg-devel] [PATCH 1/2] webmdashenc: Require the 'adaptation_sets' option to be ste

2017-04-20 Thread Michael Niedermayer
On Thu, Apr 20, 2017 at 01:14:42PM +0100, Derek Buitenhuis wrote: > This seems to be non-optional, and if the muxer is run without it, > strlen() is run on NULL, causing a segfault. > > Signed-off-by: Derek Buitenhuis > --- > libavformat/webmdashenc.c | 4 > 1

[FFmpeg-devel] [PATCH 1/2] webmdashenc: Require the 'adaptation_sets' option to be ste

2017-04-20 Thread Derek Buitenhuis
This seems to be non-optional, and if the muxer is run without it, strlen() is run on NULL, causing a segfault. Signed-off-by: Derek Buitenhuis --- libavformat/webmdashenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/webmdashenc.c