Re: [FFmpeg-devel] [PATCH 1/2 v2] avformat/avisynth: remove atexit() handler

2024-08-13 Thread Stephen Hutchinson
On 7/19/24 12:56 PM, Stephen Hutchinson wrote: The atexit() handler in the avisynth demuxer was added because there was a conflict in AvxSynth that arose due to their use of C++ global objects, particularly in relation to having added a logging function relying on log4cpp. This conflict was resp

Re: [FFmpeg-devel] [PATCH 1/2 v2] avformat/avisynth: remove atexit() handler

2024-08-11 Thread Stephen Hutchinson
On 7/28/24 11:59 AM, Stephen Hutchinson wrote: On 7/28/24 9:38 AM, Ramiro Polla wrote: @@ -1134,6 +1089,7 @@ static av_cold int avisynth_read_close(AVFormatContext *s)   return AVERROR_UNKNOWN;   avisynth_context_destroy(s->priv_data); +    dlclose(avs_library.library); Maybe it'

Re: [FFmpeg-devel] [PATCH 1/2 v2] avformat/avisynth: remove atexit() handler

2024-07-28 Thread Stephen Hutchinson
On 7/28/24 9:38 AM, Ramiro Polla wrote: @@ -1134,6 +1089,7 @@ static av_cold int avisynth_read_close(AVFormatContext *s) return AVERROR_UNKNOWN; avisynth_context_destroy(s->priv_data); +dlclose(avs_library.library); Maybe it's best to wrap this around an if (avs_library.lib

Re: [FFmpeg-devel] [PATCH 1/2 v2] avformat/avisynth: remove atexit() handler

2024-07-28 Thread Ramiro Polla
On Fri, Jul 19, 2024 at 7:51 PM Stephen Hutchinson wrote: > > The atexit() handler in the avisynth demuxer was added because > there was a conflict in AvxSynth that arose due to their use > of C++ global objects, particularly in relation to having > added a logging function relying on log4cpp. > >

Re: [FFmpeg-devel] [PATCH 1/2 v2] avformat/avisynth: remove atexit() handler

2024-07-27 Thread Stephen Hutchinson
On 7/19/24 12:56 PM, Stephen Hutchinson wrote: The atexit() handler in the avisynth demuxer was added because there was a conflict in AvxSynth that arose due to their use of C++ global objects, particularly in relation to having added a logging function relying on log4cpp. This conflict was resp

[FFmpeg-devel] [PATCH 1/2 v2] avformat/avisynth: remove atexit() handler

2024-07-19 Thread Stephen Hutchinson
The atexit() handler in the avisynth demuxer was added because there was a conflict in AvxSynth that arose due to their use of C++ global objects, particularly in relation to having added a logging function relying on log4cpp. This conflict was responsible for causing a segfault on exit. It did no