Re: [FFmpeg-devel] [PATCH 1/3] avcodec/eatgv: Check remaining size after the keyframe header

2019-07-29 Thread Michael Niedermayer
On Mon, Jul 29, 2019 at 08:49:40AM +0200, Paul B Mahol wrote: > Actually remove log message completely. ok, will apply with that change > It is invalid because it is warning > while you return error immediately. Thats true for most of the error messages in the file. Thanks [...] -- Michael

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/eatgv: Check remaining size after the keyframe header

2019-07-28 Thread Paul B Mahol
Actually remove log message completely. It is invalid because it is warning while you return error immediately. On Mon, Jul 29, 2019 at 8:48 AM Paul B Mahol wrote: > LGTM > > On Mon, Jul 29, 2019 at 1:11 AM Michael Niedermayer > wrote: > >> The minimal size which unpack() will not fail on is 5

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/eatgv: Check remaining size after the keyframe header

2019-07-28 Thread Paul B Mahol
LGTM On Mon, Jul 29, 2019 at 1:11 AM Michael Niedermayer wrote: > The minimal size which unpack() will not fail on is 5 bytes > Fixes: Timeout (14sec -> 77ms) (testcase 15508) > Fixes: > 15508/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EATGV_fuzzer-5700053513011200 > Fixes: > 15996/cluste

[FFmpeg-devel] [PATCH 1/3] avcodec/eatgv: Check remaining size after the keyframe header

2019-07-28 Thread Michael Niedermayer
The minimal size which unpack() will not fail on is 5 bytes Fixes: Timeout (14sec -> 77ms) (testcase 15508) Fixes: 15508/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EATGV_fuzzer-5700053513011200 Fixes: 15996/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EATGV_fuzzer-5751353223151616 Fo