Re: [FFmpeg-devel] [PATCH 1/3] avcodec/exr: Fix memleaks in decode_header()

2018-02-01 Thread Michael Niedermayer
On Wed, Jan 31, 2018 at 09:04:54PM +0100, Moritz Barsnick wrote: > On Wed, Jan 31, 2018 at 19:20:08 +0100, Michael Niedermayer wrote: > > > @@ -1458,8 +1465,10 @@ static int decode_header(EXRContext *s, AVFrame > > *frame) > > > > s->channels = av_realloc(s->channels, > >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/exr: Fix memleaks in decode_header()

2018-01-31 Thread Moritz Barsnick
On Wed, Jan 31, 2018 at 21:04:54 +0100, Moritz Barsnick wrote: > > +ret = AVERROR(ENOMEM);; > ^^ > Duplicate semicolon. This should have given you a new warning. Actually, no warning, yet still not desired. ___

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/exr: Fix memleaks in decode_header()

2018-01-31 Thread Moritz Barsnick
On Wed, Jan 31, 2018 at 19:20:08 +0100, Michael Niedermayer wrote: > @@ -1458,8 +1465,10 @@ static int decode_header(EXRContext *s, AVFrame *frame) > > s->channels = av_realloc(s->channels, > ++s->nb_channels * > sizeof(EXRChannel)); > -

[FFmpeg-devel] [PATCH 1/3] avcodec/exr: Fix memleaks in decode_header()

2018-01-31 Thread Michael Niedermayer
Fixes: 4793/clusterfuzz-testcase-minimized-5707366629638144 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/exr.c | 82 ++-- 1 file changed,